Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-2369

Minor typo in error message in HiveConnection.java (JDBC)

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.7.1, 0.8.0
    • Fix Version/s: 0.8.0
    • Component/s: JDBC
    • Labels:
      None
    • Environment:

      Linux

    • Hadoop Flags:
      Reviewed

      Description

      There is a minor typo issue in HiveConnection.java (jdbc) :

      throw new SQLException("Could not establish connecton to "
                  + uri + ": " + e.getMessage(), "08S01");

      It seems like there's a "i" missing.

      I know it's a very minor typo but I report it anyway. I won't attach a patch because it would be too long for me to SVN checkout just for 1 letter.

      1. HIVE-2369.patch
        0.6 kB
        Clément Notin

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user ClementNotin closed the pull request at:

          https://github.com/apache/hive/pull/3

          Show
          githubbot ASF GitHub Bot added a comment - Github user ClementNotin closed the pull request at: https://github.com/apache/hive/pull/3
          Hide
          hudson Hudson added a comment -

          Integrated in Hive-trunk-h0.21 #938 (See https://builds.apache.org/job/Hive-trunk-h0.21/938/)
          HIVE-2369. Minor typo in error message in HiveConnection.java (JDBC)
          (Clement Notin via jvs)

          jvs : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1165985
          Files :

          • /hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveConnection.java
          Show
          hudson Hudson added a comment - Integrated in Hive-trunk-h0.21 #938 (See https://builds.apache.org/job/Hive-trunk-h0.21/938/ ) HIVE-2369 . Minor typo in error message in HiveConnection.java (JDBC) (Clement Notin via jvs) jvs : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1165985 Files : /hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveConnection.java
          Hide
          jvs John Sichi added a comment -

          Committed to trunk. Thanks Clément!

          Show
          jvs John Sichi added a comment - Committed to trunk. Thanks Clément!
          Hide
          jvs John Sichi added a comment -

          +1. Will commit when tests pass.

          Show
          jvs John Sichi added a comment - +1. Will commit when tests pass.
          Hide
          cnotin Clément Notin added a comment -

          Patch

          Show
          cnotin Clément Notin added a comment - Patch
          Hide
          cnotin Clément Notin added a comment -

          Index: jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveConnection.java
          ===================================================================
          — jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveConnection.java (revision 1157240)
          +++ jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveConnection.java (working copy)
          @@ -95,7 +95,7 @@
          try

          { transport.open(); }

          catch (TTransportException e)

          { - throw new SQLException("Could not establish connecton to " + throw new SQLException("Could not establish connection to " + uri + ": " + e.getMessage(), "08S01"); }

          }

          Show
          cnotin Clément Notin added a comment - Index: jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveConnection.java =================================================================== — jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveConnection.java (revision 1157240) +++ jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveConnection.java (working copy) @@ -95,7 +95,7 @@ try { transport.open(); } catch (TTransportException e) { - throw new SQLException("Could not establish connecton to " + throw new SQLException("Could not establish connection to " + uri + ": " + e.getMessage(), "08S01"); } }
          Hide
          jghoman Jakob Homan added a comment -

          Thanks for doing this. Apache keeps all of its software in a SVN repository, so we need all the patches uploaded to JIRA in diff format (with --no-prefix if generated from git, to be compatible).

          Show
          jghoman Jakob Homan added a comment - Thanks for doing this. Apache keeps all of its software in a SVN repository, so we need all the patches uploaded to JIRA in diff format (with --no-prefix if generated from git, to be compatible).
          Hide
          cnotin Clément Notin added a comment -

          I wrote the patch on GitHub and made a pull request. You can get it there.

          Show
          cnotin Clément Notin added a comment - I wrote the patch on GitHub and made a pull request. You can get it there.
          Hide
          cnotin Clément Notin added a comment -

          Easy patch

          Show
          cnotin Clément Notin added a comment - Easy patch

            People

            • Assignee:
              cnotin Clément Notin
              Reporter:
              cnotin Clément Notin
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 2m
                2m
                Remaining:
                Remaining Estimate - 2m
                2m
                Logged:
                Time Spent - Not Specified
                Not Specified

                  Development