Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-23606

LLAP: Delay In DirectByteBuffer Clean Up For EncodedReaderImpl

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0
    • Fix Version/s: 4.0.0
    • Component/s: llap

      Description

      DirectByteBuffler are only cleaned up when there is Full GC or manually invoked cleaner method of DirectByteBuffer, Since full GC may take some time to kick in, In the meanwhile the native memory usage of LLAP daemon process might shoot up and this will force the YARN pmem monitor to kill the container running the daemon.

      HIVE-16180 tried to solve this problem, but the code structure got messed up after HIVE-15665

      The IdentityHashMap (toRelease) is initialized in https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedReaderImpl.java#L409 , but it is getting re-initialized inside the method getDataFromCacheAndDisk() https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedReaderImpl.java#L633 which makes it local to that method hence the original toRelease IdentityHashMap remains empty.

        Attachments

        1. HIVE-23606.01.patch
          0.7 kB
          Syed Shameerur Rahman

          Issue Links

            Activity

              People

              • Assignee:
                srahman Syed Shameerur Rahman
                Reporter:
                srahman Syed Shameerur Rahman
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 0.5h
                  0.5h