[HIVE-23601] Hive Statement Clear Statement Handle on Error

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 4.0.0-alpha-1
• Labels: pull-request-available
• Assignee: David Mollitor
• Reporter: David Mollitor
• Created: 03/Jun/20 14:03
• Updated: 17/Nov/22 08:48
• Resolved: 11/Jun/20 14:30

Description

  private void closeStatementIfNeeded() throws SQLException {
    try {
      if (stmtHandle != null) {
        TCloseOperationReq closeReq = new TCloseOperationReq(stmtHandle);
        TCloseOperationResp closeResp = client.CloseOperation(closeReq);
        Utils.verifySuccessWithInfo(closeResp.getStatus());
        stmtHandle = null;
      }
    } catch (SQLException e) {
      throw e;
    } catch (Exception e) {
      throw new SQLException("Failed to close statement", "08S01", e);
    }
  }

 void closeClientOperation() throws SQLException {
    closeStatementIfNeeded();
    isQueryClosed = true;
    stmtHandle = null;
  }

verifySuccessWithInfo throws an Exception if it finds an error code and therefore leapfrogs over setting the statement handle to null (twice). Probably not what is intended since the original author(s) are tried twice to null it out.

Issue Links

• links to: GitHub Pull Request #1054