[HIVE-23480] Test may fail due to a incorrect usage of a third party library

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 4.0.0-alpha-1
• Component/s: HBase Metastore
• Labels: pull-request-available
• Assignee: Panagiotis Garefalakis Assign to me
• Reporter: contextshuffling
• Created: 16/May/20 07:11
• Updated: 17/Nov/22 08:48
• Resolved: 25/May/20 07:16

Description

Tests org.apache.hadoop.hive.common.TestStatsSetupConst#testStatColumnEntriesCompat replies on Jackson to serialize the params to string. However, Jackson library uses reflection API getDeclaredFields but it does not guarantee any specific order of returned field so the order of fields in the json string might change, and thus, test can fail or pass without any changes to the code.

An example error message:

org.junit.ComparisonFailure: expected:<{"[BASIC_STATS":"true","COLUMN_STATS":{"Foo":"true"}]}> but was:<{"[COLUMN_STATS":{"Foo":"true"},"BASIC_STATS":"true"]}>
at org.apache.hadoop.hive.common.TestStatsSetupConst.testStatColumnEntriesCompat(TestStatsSetupConst.java:76)

Ideally, this test should not reply on the order returned by this API so that it generates a deterministic result.

An potential solution is to use library like https://github.com/skyscreamer/JSONassert to compare string in a order-agnostic way.

Issue Links

• links to: GitHub Pull Request #1024