[HIVE-23193] Review of Subset of Debug Logging

• Type: Improvement
• Status: Patch Available
• Priority: Minor
• Resolution: Unresolved
• Target Version/s: 4.0.0
• Assignee: David Mollitor
• Reporter: David Mollitor
• Created: 13/Apr/20 22:17
• Updated: 13/Apr/20 22:18

Description

Better yet, use parameterized messages

Will outperform the first form by a factor of at least 30, in case of a disabled logging statement.

http://www.slf4j.org/faq.html

• Use parameterized logging where appropriate
• Add logging guards if (Log.isDebugEnabled() around loops and complex debug message

Simplify the code, remove lines of code, and potentially increase performance