[HIVE-22750] Consolidate LockType naming

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Component/s: Transactions
• Assignee: Marton Bod
• Reporter: Zoltan Chovan
• Created: 20/Jan/20 12:00
• Updated: 20/Apr/20 20:29
• Resolved: 15/Apr/20 21:22

Description

Extend enum with string literal to remove unnecessary `id` to `char` casting for the LockType:

switch (lockType) {
            case EXCLUSIVE:
              lockChar = LOCK_EXCLUSIVE;
              break;
            case SHARED_READ:
              lockChar = LOCK_SHARED;
              break;
            case SHARED_WRITE:
              lockChar = LOCK_SEMI_SHARED;
              break;
          }

Consolidate LockType naming in code and schema upgrade scripts:

CASE WHEN HL.`HL_LOCK_TYPE` = 'e' THEN 'exclusive' WHEN HL.`HL_LOCK_TYPE` = 'r' THEN 'shared' WHEN HL.`HL_LOCK_TYPE` = 'w' THEN *'semi-shared'* END AS LOCK_TYPE,

Lock types:

EXCLUSIVE
EXCL_WRITE
SHARED_WRITE
SHARED_READ

Issue Links

• breaks: HIVE-23259 Fix Apache Rat validation