[HIVE-22746] Make TypeCheckProcFactory generic

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 4.0.0-alpha-1
• Component/s: CBO
• Labels: pull-request-available
• Assignee: Jesús Camacho Rodríguez
• Reporter: Jesús Camacho Rodríguez
• Created: 18/Jan/20 01:53
• Updated: 27/Feb/24 22:24
• Resolved: 27/Jan/20 17:04

Description

TypeCheckProcFactory is responsible for processing AST nodes and generating ExprNode objects from them. When we generate the expressions for Calcite planning, we go through a AST node -> ExprNode -> RexNode transformation. We would like to avoid the overhead of going through the ExprNode, and thus generate directly the RexNode from the AST.

To do that, the first step is to make TypeCheckProcFactory generic, so it can receive an expression factory and create expressions in different realms. For the time being, the only factory implementation is the ExprNode factory. Thus, this patch focuses mainly on refactoring TypeCheckProcFactory without breaking anything that is already working.

In a follow-up patch, we will create a RexNode factory and use it when we parse the query in CalcitePlanner.

Issue Links

• is required by: HIVE-23100 Create RexNode factory and use it in CalcitePlanner
• links to: GitHub Pull Request #887