Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-22428

Remove superfluous "Failed to get database" WARN Logging in ObjectStore

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.2.0
    • Fix Version/s: 4.0.0
    • Component/s: Standalone Metastore
    • Labels:
      None
    • Target Version/s:

      Description

      In my testing, I get lots of logs like this:

      	Line 26319: 2019-10-28T21:09:52,134  WARN [pool-6-thread-5] metastore.ObjectStore: Failed to get database hive.compdb, returning NoSuchObjectException
      	Line 26327: 2019-10-28T21:09:52,135  WARN [pool-6-thread-5] metastore.ObjectStore: Failed to get database hive.compdb, returning NoSuchObjectException
      	Line 26504: 2019-10-28T21:09:52,600  WARN [pool-6-thread-5] metastore.ObjectStore: Failed to get database hive.tstatsfast, returning NoSuchObjectException
      	Line 26519: 2019-10-28T21:09:52,606  WARN [pool-6-thread-5] metastore.ObjectStore: Failed to get database hive.tstatsfast, returning NoSuchObjectException
      	Line 26695: 2019-10-28T21:09:52,922  WARN [pool-6-thread-5] metastore.ObjectStore: Failed to get database hive.createDb, returning NoSuchObjectException
      	Line 26703: 2019-10-28T21:09:52,923  WARN [pool-6-thread-5] metastore.ObjectStore: Failed to get database hive.createDb, returning NoSuchObjectException
      	Line 26763: 2019-10-28T21:09:52,936  WARN [pool-6-thread-5] metastore.ObjectStore: Failed to get database hive.compdb, returning NoSuchObjectException
      	Line 26778: 2019-10-28T21:09:52,939  WARN [pool-6-thread-5] metastore.ObjectStore: Failed to get database hive.compdb, returning NoSuchObjectException
      	Line 26963: 2019-10-28T21:09:53,273  WARN [pool-6-thread-5] metastore.ObjectStore: Failed to get database hive.db1, returning NoSuchObjectException
      	Line 26978: 2019-10-28T21:09:53,276  WARN [pool-6-thread-5] metastore.ObjectStore: Failed to get database hive.db2, returning NoSuchObjectException
      	Line 26986: 2019-10-28T21:09:53,277  WARN [pool-6-thread-5] metastore.ObjectStore: Failed to get database hive.db1, returning NoSuchObjectException
      	Line 27018: 2019-10-28T21:09:53,300  WARN [pool-6-thread-5] metastore.ObjectStore: Failed to get database hive.db2, returning NoSuchObjectException
      

      This is a superfluous log message. It might be pretty common for a database to not exists if, for example, a user fat-fingers the name of the database. The code also has the bad habit of log-and-throw. Just log or throw, not both.

      Since I'm looking at this class, touch up some of the other logging as well.

        Attachments

        1. HIVE-22428.1.patch
          7 kB
          David Mollitor

          Activity

            People

            • Assignee:
              belugabehr David Mollitor
              Reporter:
              belugabehr David Mollitor
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: