[HIVE-2203] Extend concat_ws() UDF to support arrays of strings - ASF JIRA

Carl Steinbach created issue - 07/Jun/11 03:30

Carl Steinbach made changes - 21/Dec/11 02:00

Field	Original Value	New Value
Assignee		Zhenxiao Luo [ zhenxiao ]

Hide

Permalink

Phabricator added a comment - 30/Dec/11 18:36

zhenxiao requested code review of "~~HIVE-2203~~ [jira] Extend concat_ws() UDF to support arrays of strings".
Reviewers: JIRA

~~HIVE-2203~~: format GenericUDFConcatWS.java

concat_ws() should support the following type of input parameters:

concat_ws(string separator, array<string>)

TEST PLAN
EMPTY

REVISION DETAIL
https://reviews.facebook.net/D1065

AFFECTED FILES
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcatWS.java

MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/

WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/2247/

Tip: use the X-Herald-Rules header to filter Herald messages in your client.

Show

Phabricator added a comment - 30/Dec/11 18:36 zhenxiao requested code review of " HIVE-2203 [jira] Extend concat_ws() UDF to support arrays of strings". Reviewers: JIRA HIVE-2203 : format GenericUDFConcatWS.java concat_ws() should support the following type of input parameters: concat_ws(string separator, array<string>) TEST PLAN EMPTY REVISION DETAIL https://reviews.facebook.net/D1065 AFFECTED FILES ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcatWS.java MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/2247/ Tip: use the X-Herald-Rules header to filter Herald messages in your client.

Phabricator made changes - 30/Dec/11 18:36

Attachment

HIVE-2203.D1065.1.patch [ 12508945 ]

Hide

Permalink

Phabricator added a comment - 30/Dec/11 18:46

zhenxiao requested code review of "~~HIVE-2203~~ [jira] Extend concat_ws() UDF to support arrays of strings".
Reviewers: JIRA

~~HIVE-2203~~: concat_ws() UDF supports arbitrary combination of strings and arrays of strings

concat_ws() should support the following type of input parameters:

concat_ws(string separator, array<string>)

TEST PLAN
EMPTY

REVISION DETAIL
https://reviews.facebook.net/D1071

AFFECTED FILES
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcatWS.java
ql/src/test/queries/clientpositive/udf_concat_ws.q
ql/src/test/results/clientpositive/udf_concat_ws.q.out

MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/

WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/2253/

Tip: use the X-Herald-Rules header to filter Herald messages in your client.

Show

Phabricator added a comment - 30/Dec/11 18:46 zhenxiao requested code review of " HIVE-2203 [jira] Extend concat_ws() UDF to support arrays of strings". Reviewers: JIRA HIVE-2203 : concat_ws() UDF supports arbitrary combination of strings and arrays of strings concat_ws() should support the following type of input parameters: concat_ws(string separator, array<string>) TEST PLAN EMPTY REVISION DETAIL https://reviews.facebook.net/D1071 AFFECTED FILES ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcatWS.java ql/src/test/queries/clientpositive/udf_concat_ws.q ql/src/test/results/clientpositive/udf_concat_ws.q.out MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/2253/ Tip: use the X-Herald-Rules header to filter Herald messages in your client.

Phabricator made changes - 30/Dec/11 18:46

Attachment

HIVE-2203.D1071.1.patch [ 12508946 ]

Hide

Permalink

Phabricator added a comment - 30/Dec/11 18:54

zhenxiao has commented on the revision "~~HIVE-2203~~ [jira] Extend concat_ws() UDF to support arrays of strings".

This is a bad patch due to inconsistent use of Phabricator. No need to review at all.
~~HIVE-2203~~.D1071.1.patch is the correct patch.

Sorry for the inconvenience.

Zhenxiao

REVISION DETAIL
https://reviews.facebook.net/D1065

Show

Phabricator added a comment - 30/Dec/11 18:54 zhenxiao has commented on the revision " HIVE-2203 [jira] Extend concat_ws() UDF to support arrays of strings". This is a bad patch due to inconsistent use of Phabricator. No need to review at all. HIVE-2203 .D1071.1.patch is the correct patch. Sorry for the inconvenience. Zhenxiao REVISION DETAIL https://reviews.facebook.net/D1065

Zhenxiao Luo made changes - 31/Dec/11 22:26

Status

Open [ 1 ]

Patch Available [ 10002 ]

Hide

Permalink

Phabricator added a comment - 04/Jan/12 02:12

cwsteinbach has requested changes to the revision "~~HIVE-2203~~ [jira] Extend concat_ws() UDF to support arrays of strings".

INLINE COMMENTS
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcatWS.java:36 I think this should be changed to:

CONCAT_WS(sep, [string | array(string)]+)
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcatWS.java:69 Please add a negative testcase that exercises this validation code. Other examples of this are available here: ql/src/test/queries/clientnegative/udf_*.q

ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcatWS.java:62 Can you rewrite this using switch statements? I generally find that easier to read.
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcatWS.java:99 Indentation is wrong here. Please use 2 character indents.
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcatWS.java:103 Leave a space after semicolons in a for statement.
ql/src/test/queries/clientpositive/udf_concat_ws.q:20 Please add an EXPLAIN query.
ql/src/test/queries/clientpositive/udf_concat_ws.q:28 Maybe replace this query with one call to concat_ws(NULL, ....) in the previous query?

REVISION DETAIL
https://reviews.facebook.net/D1071

Show

Phabricator added a comment - 04/Jan/12 02:12 cwsteinbach has requested changes to the revision " HIVE-2203 [jira] Extend concat_ws() UDF to support arrays of strings". INLINE COMMENTS ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcatWS.java:36 I think this should be changed to: CONCAT_WS(sep, [string | array(string)] +) ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcatWS.java:69 Please add a negative testcase that exercises this validation code. Other examples of this are available here: ql/src/test/queries/clientnegative/udf_*.q ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcatWS.java:62 Can you rewrite this using switch statements? I generally find that easier to read. ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcatWS.java:99 Indentation is wrong here. Please use 2 character indents. ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcatWS.java:103 Leave a space after semicolons in a for statement. ql/src/test/queries/clientpositive/udf_concat_ws.q:20 Please add an EXPLAIN query. ql/src/test/queries/clientpositive/udf_concat_ws.q:28 Maybe replace this query with one call to concat_ws(NULL, ....) in the previous query? REVISION DETAIL https://reviews.facebook.net/D1071

Carl Steinbach made changes - 04/Jan/12 02:13

Status

Patch Available [ 10002 ]

Open [ 1 ]

Hide

Permalink

Phabricator added a comment - 04/Jan/12 18:47

zhenxiao requested code review of "~~HIVE-2203~~ [jira] Extend concat_ws() UDF to support arrays of strings".
Reviewers: JIRA

~~HIVE-2203~~: resolve trailing whitespace

concat_ws() should support the following type of input parameters:

concat_ws(string separator, array<string>)

TEST PLAN
EMPTY

REVISION DETAIL
https://reviews.facebook.net/D1113

AFFECTED FILES
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcatWS.java

MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/

WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/2331/

Tip: use the X-Herald-Rules header to filter Herald messages in your client.

Show

Phabricator added a comment - 04/Jan/12 18:47 zhenxiao requested code review of " HIVE-2203 [jira] Extend concat_ws() UDF to support arrays of strings". Reviewers: JIRA HIVE-2203 : resolve trailing whitespace concat_ws() should support the following type of input parameters: concat_ws(string separator, array<string>) TEST PLAN EMPTY REVISION DETAIL https://reviews.facebook.net/D1113 AFFECTED FILES ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcatWS.java MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/2331/ Tip: use the X-Herald-Rules header to filter Herald messages in your client.

Phabricator made changes - 04/Jan/12 18:47

Attachment

HIVE-2203.D1113.1.patch [ 12509440 ]

Hide

Permalink

Phabricator added a comment - 04/Jan/12 19:01

zhenxiao requested code review of "~~HIVE-2203~~ [jira] Extend concat_ws() UDF to support arrays of strings".
Reviewers: JIRA

~~HIVE-2203~~: Extend concat_ws() UDF to support arrays of strings

concat_ws() should support the following type of input parameters:

concat_ws(string separator, array<string>)

TEST PLAN
EMPTY

REVISION DETAIL
https://reviews.facebook.net/D1119

AFFECTED FILES
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcatWS.java
ql/src/test/queries/clientnegative/udf_concat_ws_wrong1.q
ql/src/test/queries/clientnegative/udf_concat_ws_wrong2.q
ql/src/test/queries/clientnegative/udf_concat_ws_wrong3.q
ql/src/test/queries/clientpositive/udf_concat_ws.q
ql/src/test/results/clientnegative/udf_concat_ws_wrong1.q.out
ql/src/test/results/clientnegative/udf_concat_ws_wrong2.q.out
ql/src/test/results/clientnegative/udf_concat_ws_wrong3.q.out
ql/src/test/results/clientpositive/udf_concat_ws.q.out

MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/

WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/2343/

Tip: use the X-Herald-Rules header to filter Herald messages in your client.

Show

Phabricator added a comment - 04/Jan/12 19:01 zhenxiao requested code review of " HIVE-2203 [jira] Extend concat_ws() UDF to support arrays of strings". Reviewers: JIRA HIVE-2203 : Extend concat_ws() UDF to support arrays of strings concat_ws() should support the following type of input parameters: concat_ws(string separator, array<string>) TEST PLAN EMPTY REVISION DETAIL https://reviews.facebook.net/D1119 AFFECTED FILES ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcatWS.java ql/src/test/queries/clientnegative/udf_concat_ws_wrong1.q ql/src/test/queries/clientnegative/udf_concat_ws_wrong2.q ql/src/test/queries/clientnegative/udf_concat_ws_wrong3.q ql/src/test/queries/clientpositive/udf_concat_ws.q ql/src/test/results/clientnegative/udf_concat_ws_wrong1.q.out ql/src/test/results/clientnegative/udf_concat_ws_wrong2.q.out ql/src/test/results/clientnegative/udf_concat_ws_wrong3.q.out ql/src/test/results/clientpositive/udf_concat_ws.q.out MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/2343/ Tip: use the X-Herald-Rules header to filter Herald messages in your client.

Phabricator made changes - 04/Jan/12 19:01

Attachment

HIVE-2203.D1119.1.patch [ 12509444 ]

Hide

Permalink

Phabricator added a comment - 04/Jan/12 19:03

zhenxiao has commented on the revision "~~HIVE-2203~~ [jira] Extend concat_ws() UDF to support arrays of strings".

Invalid patch. D1119 is the correct one for review.

REVISION DETAIL
https://reviews.facebook.net/D1113

Show

Phabricator added a comment - 04/Jan/12 19:03 zhenxiao has commented on the revision " HIVE-2203 [jira] Extend concat_ws() UDF to support arrays of strings". Invalid patch. D1119 is the correct one for review. REVISION DETAIL https://reviews.facebook.net/D1113

Zhenxiao Luo made changes - 04/Jan/12 19:04

Status

Open [ 1 ]

Patch Available [ 10002 ]

Carl Steinbach made changes - 09/Jan/12 09:22

Status

Patch Available [ 10002 ]

Open [ 1 ]

Hide

Permalink

Phabricator added a comment - 09/Jan/12 09:22

cwsteinbach has requested changes to the revision "~~HIVE-2203~~ [jira] Extend concat_ws() UDF to support arrays of strings".

INLINE COMMENTS
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcatWS.java:64 Calling getTypeName and comparing strings is hacky. Instead lets cast the oi to a ListObjectInspector and call getListElementObjectInspector().
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcatWS.java:114 Indentation.

REVISION DETAIL
https://reviews.facebook.net/D1119

Show

Phabricator added a comment - 09/Jan/12 09:22 cwsteinbach has requested changes to the revision " HIVE-2203 [jira] Extend concat_ws() UDF to support arrays of strings". INLINE COMMENTS ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcatWS.java:64 Calling getTypeName and comparing strings is hacky. Instead lets cast the oi to a ListObjectInspector and call getListElementObjectInspector(). ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcatWS.java:114 Indentation. REVISION DETAIL https://reviews.facebook.net/D1119

Hide

Permalink

Phabricator added a comment - 09/Jan/12 18:20

zhenxiao requested code review of "~~HIVE-2203~~ [jira] Extend concat_ws() UDF to support arrays of strings".
Reviewers: JIRA

~~HIVE-2203~~: Extend concat_ws() UDF to support arrays of strings

concat_ws() should support the following type of input parameters:

concat_ws(string separator, array<string>)

TEST PLAN
EMPTY

REVISION DETAIL
https://reviews.facebook.net/D1137

AFFECTED FILES
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcatWS.java
ql/src/test/queries/clientnegative/udf_concat_ws_wrong1.q
ql/src/test/queries/clientnegative/udf_concat_ws_wrong2.q
ql/src/test/queries/clientnegative/udf_concat_ws_wrong3.q
ql/src/test/queries/clientpositive/udf_concat_ws.q
ql/src/test/results/clientnegative/udf_concat_ws_wrong1.q.out
ql/src/test/results/clientnegative/udf_concat_ws_wrong2.q.out
ql/src/test/results/clientnegative/udf_concat_ws_wrong3.q.out
ql/src/test/results/clientpositive/udf_concat_ws.q.out

MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/

WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/2409/

Tip: use the X-Herald-Rules header to filter Herald messages in your client.

Show

Phabricator added a comment - 09/Jan/12 18:20 zhenxiao requested code review of " HIVE-2203 [jira] Extend concat_ws() UDF to support arrays of strings". Reviewers: JIRA HIVE-2203 : Extend concat_ws() UDF to support arrays of strings concat_ws() should support the following type of input parameters: concat_ws(string separator, array<string>) TEST PLAN EMPTY REVISION DETAIL https://reviews.facebook.net/D1137 AFFECTED FILES ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcatWS.java ql/src/test/queries/clientnegative/udf_concat_ws_wrong1.q ql/src/test/queries/clientnegative/udf_concat_ws_wrong2.q ql/src/test/queries/clientnegative/udf_concat_ws_wrong3.q ql/src/test/queries/clientpositive/udf_concat_ws.q ql/src/test/results/clientnegative/udf_concat_ws_wrong1.q.out ql/src/test/results/clientnegative/udf_concat_ws_wrong2.q.out ql/src/test/results/clientnegative/udf_concat_ws_wrong3.q.out ql/src/test/results/clientpositive/udf_concat_ws.q.out MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/2409/ Tip: use the X-Herald-Rules header to filter Herald messages in your client.

Phabricator made changes - 09/Jan/12 18:20

Attachment

HIVE-2203.D1137.1.patch [ 12509940 ]

Zhenxiao Luo made changes - 10/Jan/12 05:08

Status

Open [ 1 ]

Patch Available [ 10002 ]

Hide

Permalink

Carl Steinbach added a comment - 16/Jan/12 09:57

@Zhenxiao: Please attach a copy of the patch (D1137) and give license rights to Apache.

Show

Carl Steinbach added a comment - 16/Jan/12 09:57 @Zhenxiao: Please attach a copy of the patch (D1137) and give license rights to Apache.

Carl Steinbach made changes - 16/Jan/12 09:57

Status

Patch Available [ 10002 ]

Open [ 1 ]

Hide

Permalink

Phabricator added a comment - 16/Jan/12 09:57

cwsteinbach has accepted the revision "~~HIVE-2203~~ [jira] Extend concat_ws() UDF to support arrays of strings".

+1

REVISION DETAIL
https://reviews.facebook.net/D1137

Show

Phabricator added a comment - 16/Jan/12 09:57 cwsteinbach has accepted the revision " HIVE-2203 [jira] Extend concat_ws() UDF to support arrays of strings". +1 REVISION DETAIL https://reviews.facebook.net/D1137

Zhenxiao Luo made changes - 16/Jan/12 18:41

Attachment

HIVE-2203.D1137.1.patch [ 12510729 ]

Zhenxiao Luo made changes - 16/Jan/12 18:41

Status

Open [ 1 ]

Patch Available [ 10002 ]

Hide

Permalink

Carl Steinbach added a comment - 20/Jan/12 21:32

Committed to trunk. Thanks Zhenxiao!

Show

Carl Steinbach added a comment - 20/Jan/12 21:32 Committed to trunk. Thanks Zhenxiao!

Carl Steinbach made changes - 20/Jan/12 21:32

Fix Version/s		0.9.0 [ 12317742 ]
Resolution		Fixed [ 1 ]
Status	Patch Available [ 10002 ]	Resolved [ 5 ]
Hadoop Flags		Reviewed [ 10343 ]

Hide

Permalink

Hudson added a comment - 21/Jan/12 06:03

Integrated in Hive-trunk-h0.21 #1211 (See https://builds.apache.org/job/Hive-trunk-h0.21/1211/)
~~HIVE-2203~~. Extend concat_ws() UDF to support arrays of strings (Zhenxiao Luo via cws)

cws : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1234150
Files :

/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcatWS.java
/hive/trunk/ql/src/test/queries/clientnegative/udf_concat_ws_wrong1.q
/hive/trunk/ql/src/test/queries/clientnegative/udf_concat_ws_wrong2.q
/hive/trunk/ql/src/test/queries/clientnegative/udf_concat_ws_wrong3.q
/hive/trunk/ql/src/test/queries/clientpositive/udf_concat_ws.q
/hive/trunk/ql/src/test/results/clientnegative/udf_concat_ws_wrong1.q.out
/hive/trunk/ql/src/test/results/clientnegative/udf_concat_ws_wrong2.q.out
/hive/trunk/ql/src/test/results/clientnegative/udf_concat_ws_wrong3.q.out
/hive/trunk/ql/src/test/results/clientpositive/udf_concat_ws.q.out

Show

Hudson added a comment - 21/Jan/12 06:03 Integrated in Hive-trunk-h0.21 #1211 (See https://builds.apache.org/job/Hive-trunk-h0.21/1211/ ) HIVE-2203 . Extend concat_ws() UDF to support arrays of strings (Zhenxiao Luo via cws) cws : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1234150 Files : /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcatWS.java /hive/trunk/ql/src/test/queries/clientnegative/udf_concat_ws_wrong1.q /hive/trunk/ql/src/test/queries/clientnegative/udf_concat_ws_wrong2.q /hive/trunk/ql/src/test/queries/clientnegative/udf_concat_ws_wrong3.q /hive/trunk/ql/src/test/queries/clientpositive/udf_concat_ws.q /hive/trunk/ql/src/test/results/clientnegative/udf_concat_ws_wrong1.q.out /hive/trunk/ql/src/test/results/clientnegative/udf_concat_ws_wrong2.q.out /hive/trunk/ql/src/test/results/clientnegative/udf_concat_ws_wrong3.q.out /hive/trunk/ql/src/test/results/clientpositive/udf_concat_ws.q.out

Hide

Permalink

Ashutosh Chauhan added a comment - 30/Apr/12 22:11

This issue is closed now. It was released with the fix in 0.9.0. If there is a problem, please open a new jira and link this one with that.

Show

Ashutosh Chauhan added a comment - 30/Apr/12 22:11 This issue is closed now. It was released with the fix in 0.9.0. If there is a problem, please open a new jira and link this one with that.

Ashutosh Chauhan made changes - 30/Apr/12 22:11

Status

Resolved [ 5 ]

Closed [ 6 ]

Hide

Permalink

Phabricator added a comment - 11/Dec/12 00:25

zhenxiao has abandoned the revision "~~HIVE-2203~~ [jira] Extend concat_ws() UDF to support arrays of strings".

REVISION DETAIL
https://reviews.facebook.net/D1065

To: JIRA, zhenxiao
Cc: zhenxiao

Show

Phabricator added a comment - 11/Dec/12 00:25 zhenxiao has abandoned the revision " HIVE-2203 [jira] Extend concat_ws() UDF to support arrays of strings". REVISION DETAIL https://reviews.facebook.net/D1065 To: JIRA, zhenxiao Cc: zhenxiao

Hide

Permalink

Phabricator added a comment - 11/Dec/12 00:27

zhenxiao has abandoned the revision "~~HIVE-2203~~ [jira] Extend concat_ws() UDF to support arrays of strings".

REVISION DETAIL
https://reviews.facebook.net/D1113

To: JIRA, zhenxiao
Cc: zhenxiao

Show

Phabricator added a comment - 11/Dec/12 00:27 zhenxiao has abandoned the revision " HIVE-2203 [jira] Extend concat_ws() UDF to support arrays of strings". REVISION DETAIL https://reviews.facebook.net/D1113 To: JIRA, zhenxiao Cc: zhenxiao

Hide

Permalink

Phabricator added a comment - 11/Dec/12 00:53

zhenxiao has closed the revision "~~HIVE-2203~~ [jira] Extend concat_ws() UDF to support arrays of strings".

REVISION DETAIL
https://reviews.facebook.net/D1137

To: JIRA, cwsteinbach, zhenxiao
Cc: cwsteinbach

Show

Phabricator added a comment - 11/Dec/12 00:53 zhenxiao has closed the revision " HIVE-2203 [jira] Extend concat_ws() UDF to support arrays of strings". REVISION DETAIL https://reviews.facebook.net/D1137 To: JIRA, cwsteinbach, zhenxiao Cc: cwsteinbach

Hide

Permalink

Hudson added a comment - 09/Jan/13 10:23

Integrated in Hive-trunk-hadoop2 #54 (See https://builds.apache.org/job/Hive-trunk-hadoop2/54/)
~~HIVE-2203~~. Extend concat_ws() UDF to support arrays of strings (Zhenxiao Luo via cws) (Revision 1234150)

Result = ABORTED
cws : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1234150
Files :

/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcatWS.java
/hive/trunk/ql/src/test/queries/clientnegative/udf_concat_ws_wrong1.q
/hive/trunk/ql/src/test/queries/clientnegative/udf_concat_ws_wrong2.q
/hive/trunk/ql/src/test/queries/clientnegative/udf_concat_ws_wrong3.q
/hive/trunk/ql/src/test/queries/clientpositive/udf_concat_ws.q
/hive/trunk/ql/src/test/results/clientnegative/udf_concat_ws_wrong1.q.out
/hive/trunk/ql/src/test/results/clientnegative/udf_concat_ws_wrong2.q.out
/hive/trunk/ql/src/test/results/clientnegative/udf_concat_ws_wrong3.q.out
/hive/trunk/ql/src/test/results/clientpositive/udf_concat_ws.q.out

Show

Hudson added a comment - 09/Jan/13 10:23 Integrated in Hive-trunk-hadoop2 #54 (See https://builds.apache.org/job/Hive-trunk-hadoop2/54/ ) HIVE-2203 . Extend concat_ws() UDF to support arrays of strings (Zhenxiao Luo via cws) (Revision 1234150) Result = ABORTED cws : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1234150 Files : /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcatWS.java /hive/trunk/ql/src/test/queries/clientnegative/udf_concat_ws_wrong1.q /hive/trunk/ql/src/test/queries/clientnegative/udf_concat_ws_wrong2.q /hive/trunk/ql/src/test/queries/clientnegative/udf_concat_ws_wrong3.q /hive/trunk/ql/src/test/queries/clientpositive/udf_concat_ws.q /hive/trunk/ql/src/test/results/clientnegative/udf_concat_ws_wrong1.q.out /hive/trunk/ql/src/test/results/clientnegative/udf_concat_ws_wrong2.q.out /hive/trunk/ql/src/test/results/clientnegative/udf_concat_ws_wrong3.q.out /hive/trunk/ql/src/test/results/clientpositive/udf_concat_ws.q.out

Extend concat_ws() UDF to support arrays of strings

Details

Description

Attachments

Activity

People

Dates

Development

Agile