Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-21346 Refactor Hive DDL
  3. HIVE-21693

Break up DDLTask - extract Process related operations

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 3.1.1
    • 4.0.0-alpha-1
    • Hive

    Description

      DDLTask is a huge class, more than 5000 lines long. The related DDLWork is also a huge class, which has a field for each DDL operation it supports. The goal is to refactor these in order to have everything cut into more handleable classes under the package  org.apache.hadoop.hive.ql.exec.ddl:

      • have a separate class for each operation
      • have a package for each operation group (database ddl, table ddl, etc), so the amount of classes under a package is more manageable
      • make all the requests (DDLDesc subclasses) immutable
      • DDLTask should be agnostic to the actual operations
      • right now let's ignore the issue of having some operations handled by DDLTask which are not actual DDL operations (lock, unlock, desc...)

      In the interim time when there are two DDLTask and DDLWork classes in the code base the new ones in the new package are called DDLTask2 and DDLWork2 thus avoiding the usage of fully qualified class names where both the old and the new classes are in use.

      Step #7: extract all the process related operations from the old DDLTask, and move them under the new package.

      Attachments

        1. HIVE-21693.03.patch
          139 kB
          Miklos Gergely
        2. HIVE-21693.02.patch
          135 kB
          Miklos Gergely
        3. HIVE-21693.01.patch
          131 kB
          Miklos Gergely

        Issue Links

          Activity

            People

              mgergely Miklos Gergely
              mgergely Miklos Gergely
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: