Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-21586

Thrift generated cpp files for metastore do not compile

Log workAgile BoardRank to TopRank to BottomVotersWatch issueWatchersCreate sub-taskConvert to sub-taskMoveLinkCloneLabelsUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.1.0
    • Fix Version/s: 3.2.0, 4.0.0
    • Component/s: Standalone Metastore
    • Labels:
      None

      Description

      The way some structs like CreationMetadata, CompactionInfo, ColumnStatistics are defined in hive_metastore.thrift is that these structs are used before they are defined. While this works for the java code which is generated, it does not work for the generated cpp code since Thrift does not use pointer/references to the forward declared classes.

      The easy fix for this would be to reorder the struct definitions in the hive_metastore.thrift so that they are always defined before they are used.

        Attachments

        1. HIVE-21586.05.patch
          393 kB
          Vihang Karajgaonkar
        2. HIVE-21586.04.patch
          358 kB
          Vihang Karajgaonkar
        3. HIVE-21586.04.branch-3.patch
          728 kB
          Vihang Karajgaonkar
        4. HIVE-21586.03.patch
          508 kB
          Vihang Karajgaonkar
        5. HIVE-21586.02.patch
          508 kB
          Vihang Karajgaonkar
        6. HIVE-21586.nothrift.patch
          3 kB
          Vihang Karajgaonkar
        7. HIVE-21586.01.patch
          508 kB
          Vihang Karajgaonkar

        Issue Links

          Activity

          $i18n.getText('security.level.explanation', $currentSelection) Viewable by All Users
          Cancel

            People

            • Assignee:
              vihangk1 Vihang Karajgaonkar Assign to me
              Reporter:
              vihangk1 Vihang Karajgaonkar

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment