[HIVE-21172] DEFAULT keyword handling in MERGE UPDATE clause issues

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.0.0
• Component/s: SQL, Transactions
• Labels: pull-request-available
• Target Version/s: 4.0.0
• Assignee: Krisztian Kasa
• Reporter: Eugene Koifman
• Created: 26/Jan/19 01:17
• Updated: 15/Dec/21 11:44
• Resolved: 15/Dec/21 11:44

Description

once HIVE-21159 lands, enable HiveConf.MERGE_SPLIT_UPDATE and run these tests.

TestMiniLlapLocalCliDriver.testCliDriver[sqlmerge_stats]
mvn test -Dtest=TestMiniLlapLocalCliDriver -Dqfile=insert_into_default_keyword.q

Merge is rewritten as a multi-insert. When Update clause has DEFAULT, it's not properly replaced with a value in the muli-insert - it's treated as a literal

INSERT INTO `default`.`acidTable`    -- update clause(insert part)
 SELECT `t`.`key`, `DEFAULT`, `t`.`value`
   WHERE `t`.`key` = `s`.`key` AND `s`.`key` > 3 AND NOT(`s`.`key` < 3)

See LOG.info("Going to reparse <" + originalQuery + "> as \n<" + rewrittenQueryStr.toString() + ">"); in hive.log

MergeSemanticAnalyzer.replaceDefaultKeywordForMerge() is only called in handleInsert but not handleUpdate(). Why does issue only show up with MERGE_SPLIT_UPDATE?

Once this is fixed, HiveConf.MERGE_SPLIT_UPDATE should be true by default

Issue Links

• requires: HIVE-21159 Modify Merge statement logic to perform Update split early
• links to: GitHub Pull Request #2857