[HIVE-20896] CachedStore fail to cache stats in multiple code paths

• Type: Bug
• Status: Patch Available
• Priority: Major
• Resolution: Unresolved
• Component/s: Standalone Metastore
• Target Version/s: 4.0.0
• Assignee: Daniel Dai
• Reporter: Daniel Dai
• Created: 09/Nov/18 06:34
• Updated: 14/Dec/18 07:08

Description

Bunch of issues discovered in CachedStore to keep up column statistics:
1. The criteria for partition/non-partition is wrong (table.isSetPartitionKeys() is always true)
2. In update(), partition column stats are removed when populate table basic stats
3. Dirty flags are true right after prewarm(), so the first update() does not do anything
4. Could invoke cacheLock without holding the lock, which results a freeze in update()