Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-20847

Review of NullScan Code

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 3.2.0, 4.0.0
    • 4.0.0, 4.0.0-alpha-1
    • Physical Optimizer
    • None
    • Patch

    Description

      What got me looking at this class was the verboseness of some of the logging. I would like to request that we DEBUG the logging since this level of detail means nothing to a cluster admin.

      Also... this contains call would be better applied onto a HashSet instead of an ArrayList.

      NullScanTaskDispatcher.java
        private void processAlias(MapWork work, Path path, ArrayList<String> aliasesAffected, ArrayList<String> aliases) {
          // the aliases that are allowed to map to a null scan.
          ArrayList<String> allowed = new ArrayList<String>();
          for (String alias : aliasesAffected) {
            if (aliases.contains(alias)) {
              allowed.add(alias);
            }
          }
      

      Attachments

        1. HIVE-20847.1.patch
          12 kB
          David Mollitor
        2. HIVE-20847.1.patch
          12 kB
          David Mollitor
        3. HIVE-20847.1.patch
          12 kB
          David Mollitor
        4. HIVE-20847.2.patch
          16 kB
          David Mollitor
        5. HIVE-20847.3.patch
          16 kB
          David Mollitor
        6. HIVE-20847.4.patch
          16 kB
          David Mollitor

        Activity

          People

            belugabehr David Mollitor
            belugabehr David Mollitor
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: