Hive
  1. Hive
  2. HIVE-2052

PostHook and PreHook API to add flag to indicate it is pre or post hook plus cache for content summary

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.8.0
    • Component/s: None
    • Labels:
      None

      Description

      This will allow hooks to share some information better and reduce their latency

      1. HIVE-2052.3.patch
        14 kB
        Siying Dong
      2. HIVE-2052.2.patch
        14 kB
        Siying Dong
      3. HIVE-2052.1.patch
        10 kB
        Siying Dong
      4. HIVE-2051.3.patch
        14 kB
        Siying Dong

        Activity

        Hide
        Amareshwari Sriramadasu added a comment -

        Can you validate HookContext.getInputPathToContentSummary() api also in your testcase?

        Show
        Amareshwari Sriramadasu added a comment - Can you validate HookContext.getInputPathToContentSummary() api also in your testcase?
        Hide
        Siying Dong added a comment -

        add a test case for check HookContext.getInputPathToContentSummary().

        Show
        Siying Dong added a comment - add a test case for check HookContext.getInputPathToContentSummary().
        Hide
        Joydeep Sen Sarma added a comment -

        small nits:

        • setinputpathtocontentsummary is called twice on the same hookcontext object
        • we are setting the hook type again and again (can do it once before calling postexecute)

        should the inputpathtocontentsummary be marked final in the hook and passed along with the constructor? (why would we ever change the map to a new one?).

        Show
        Joydeep Sen Sarma added a comment - small nits: setinputpathtocontentsummary is called twice on the same hookcontext object we are setting the hook type again and again (can do it once before calling postexecute) should the inputpathtocontentsummary be marked final in the hook and passed along with the constructor? (why would we ever change the map to a new one?).
        Hide
        Siying Dong added a comment -

        Modify as Joydeep's comments.

        Show
        Siying Dong added a comment - Modify as Joydeep's comments.
        Hide
        Joydeep Sen Sarma added a comment -

        looks like the new patch is for HIVE-2051 not HIVE-2052!

        Show
        Joydeep Sen Sarma added a comment - looks like the new patch is for HIVE-2051 not HIVE-2052 !
        Hide
        Siying Dong added a comment -

        the name is wrong but the content is right. I'll fix it now.

        Show
        Siying Dong added a comment - the name is wrong but the content is right. I'll fix it now.
        Hide
        Joydeep Sen Sarma added a comment -

        committed - thanks Siying!

        Show
        Joydeep Sen Sarma added a comment - committed - thanks Siying!

          People

          • Assignee:
            Siying Dong
            Reporter:
            Siying Dong
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development