[HIVE-20416] LLAP: Fail to package LLAP if the Xmx computed is too low

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Component/s: llap
• Assignee: Gopal Vijayaraghavan
• Reporter: Gopal Vijayaraghavan
• Created: 17/Aug/18 22:42
• Updated: 17/Aug/18 22:43

Description

      if (options.getXmx() != -1) {
        // Needs more explanation here
        // Xmx is not the max heap value in JDK8. You need to subtract 50% of the survivor fraction
        // from this, to get actual usable memory before it goes into GC
        xmx = options.getXmx();
        long xmxMb = (xmx / (1024L * 1024L));
        conf.setLong(ConfVars.LLAP_DAEMON_MEMORY_PER_INSTANCE_MB.varname, xmxMb);
        propsDirectOptions.setProperty(ConfVars.LLAP_DAEMON_MEMORY_PER_INSTANCE_MB.varname,
            String.valueOf(xmxMb));

needs a check for the value being so low that start-up (or all queries) will fail.