Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.8.0
    • Component/s: Metastore
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Provide to way to observe changes happening on Metastore

      1. metastore_listener.patch
        7 kB
        Ashutosh Chauhan
      2. metastore_listener.patch
        9 kB
        Ashutosh Chauhan
      3. metastore_listener.patch
        9 kB
        Ashutosh Chauhan
      4. hive-2038.patch
        17 kB
        Ashutosh Chauhan
      5. hive_2038_4.patch
        33 kB
        Ashutosh Chauhan
      6. hive_2038_3.patch
        32 kB
        Ashutosh Chauhan

        Issue Links

          Activity

          Hide
          Ashutosh Chauhan added a comment -

          Every time some change on metastore takes
          place, we have some logic which needs to be run. For example, if a new
          table is getting created in metastore I want to send a message to a
          message bus.

          Show
          Ashutosh Chauhan added a comment - Every time some change on metastore takes place, we have some logic which needs to be run. For example, if a new table is getting created in metastore I want to send a message to a message bus.
          Hide
          Ashutosh Chauhan added a comment -

          Proposed interface. Not polished and complete. Posting early to get feedback if this looks viable way to achieve the desired functionality.

          Show
          Ashutosh Chauhan added a comment - Proposed interface. Not polished and complete. Posting early to get feedback if this looks viable way to achieve the desired functionality.
          Hide
          Ashutosh Chauhan added a comment -

          Missed couple of files. In svn, you need to svn add files. Spoiled by git goodness.

          Show
          Ashutosh Chauhan added a comment - Missed couple of files. In svn, you need to svn add files. Spoiled by git goodness.
          Hide
          Ashutosh Chauhan added a comment -

          The patch is ready for review.

          Show
          Ashutosh Chauhan added a comment - The patch is ready for review.
          Hide
          Carl Steinbach added a comment -

          @Ashutosh: Can you please post a review request? Thanks!

          Show
          Carl Steinbach added a comment - @Ashutosh: Can you please post a review request? Thanks!
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/581/
          -----------------------------------------------------------

          Review request for hive, Carl Steinbach, John Sichi, and Paul Yang.

          Summary
          -------

          Review request for HIVE-2038

          This addresses bug HIVE-2038.
          https://issues.apache.org/jira/browse/HIVE-2038

          Diffs


          trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1079575
          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1079575
          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreListener.java PRE-CREATION
          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/NoOpListener.java PRE-CREATION
          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 1079575
          trunk/metastore/src/test/org/apache/hadoop/hive/metastore/DummyListener.java PRE-CREATION
          trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreListener.java PRE-CREATION

          Diff: https://reviews.apache.org/r/581/diff

          Testing
          -------

          Unit test with dummy listener included. Also tested with an alternate listener which sends a message on a message bus.

          Thanks,

          Ashutosh

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/581/ ----------------------------------------------------------- Review request for hive, Carl Steinbach, John Sichi, and Paul Yang. Summary ------- Review request for HIVE-2038 This addresses bug HIVE-2038 . https://issues.apache.org/jira/browse/HIVE-2038 Diffs trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1079575 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1079575 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreListener.java PRE-CREATION trunk/metastore/src/java/org/apache/hadoop/hive/metastore/NoOpListener.java PRE-CREATION trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 1079575 trunk/metastore/src/test/org/apache/hadoop/hive/metastore/DummyListener.java PRE-CREATION trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreListener.java PRE-CREATION Diff: https://reviews.apache.org/r/581/diff Testing ------- Unit test with dummy listener included. Also tested with an alternate listener which sends a message on a message bus. Thanks, Ashutosh
          Hide
          Carl Steinbach added a comment -

          Please see my comments on reviewboard. Thanks.

          Show
          Carl Steinbach added a comment - Please see my comments on reviewboard. Thanks.
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/581/#review428
          -----------------------------------------------------------

          trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
          <https://reviews.apache.org/r/581/#comment808>

          Please add this property to hive-default.xml along with a description of what it does.

          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
          <https://reviews.apache.org/r/581/#comment809>

          Please run checkstyle and correct any violations included in your patch.

          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
          <https://reviews.apache.org/r/581/#comment810>

          No need to reference "this", right?

          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreListener.java
          <https://reviews.apache.org/r/581/#comment815>

          What do you think about changing the name to MetaStoreEventListener or CatalogEventListener?

          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreListener.java
          <https://reviews.apache.org/r/581/#comment811>

          Please add some javadoc explaining the intended use of this interface.

          • Are the methods called before or after an action completes? What happens if a metastore operation fails?
          • Are the methods allowed to block? Are they run in a separate thread?
          • Are the methods allowed to modify the catalog objects that are passed in as parameters?

          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreListener.java
          <https://reviews.apache.org/r/581/#comment812>

          Checkstyle.

          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreListener.java
          <https://reviews.apache.org/r/581/#comment816>

          Instead of passing in raw Table/Partition/Database objects it may be better to instead wrap these objects in containers, e.g. CreateTableEvent, DropTableEvent, etc. Eventually this interface will probably include onAlterTable() and onAlterPartition(), and programmers will probably want to access both the before and after versions of a Table/Partition, etc.

          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java
          <https://reviews.apache.org/r/581/#comment813>

          Unrelated bugfix?

          trunk/metastore/src/test/org/apache/hadoop/hive/metastore/DummyListener.java
          <https://reviews.apache.org/r/581/#comment814>

          Checkstyle.

          • Carl

          On 2011-04-12 01:29:41, Ashutosh Chauhan wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/581/

          -----------------------------------------------------------

          (Updated 2011-04-12 01:29:41)

          Review request for hive, Carl Steinbach, John Sichi, and Paul Yang.

          Summary

          -------

          Review request for HIVE-2038

          This addresses bug HIVE-2038.

          https://issues.apache.org/jira/browse/HIVE-2038

          Diffs

          -----

          trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1079575

          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1079575

          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreListener.java PRE-CREATION

          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/NoOpListener.java PRE-CREATION

          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 1079575

          trunk/metastore/src/test/org/apache/hadoop/hive/metastore/DummyListener.java PRE-CREATION

          trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreListener.java PRE-CREATION

          Diff: https://reviews.apache.org/r/581/diff

          Testing

          -------

          Unit test with dummy listener included. Also tested with an alternate listener which sends a message on a message bus.

          Thanks,

          Ashutosh

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/581/#review428 ----------------------------------------------------------- trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java < https://reviews.apache.org/r/581/#comment808 > Please add this property to hive-default.xml along with a description of what it does. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java < https://reviews.apache.org/r/581/#comment809 > Please run checkstyle and correct any violations included in your patch. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java < https://reviews.apache.org/r/581/#comment810 > No need to reference "this", right? trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreListener.java < https://reviews.apache.org/r/581/#comment815 > What do you think about changing the name to MetaStoreEventListener or CatalogEventListener? trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreListener.java < https://reviews.apache.org/r/581/#comment811 > Please add some javadoc explaining the intended use of this interface. Are the methods called before or after an action completes? What happens if a metastore operation fails? Are the methods allowed to block? Are they run in a separate thread? Are the methods allowed to modify the catalog objects that are passed in as parameters? trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreListener.java < https://reviews.apache.org/r/581/#comment812 > Checkstyle. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreListener.java < https://reviews.apache.org/r/581/#comment816 > Instead of passing in raw Table/Partition/Database objects it may be better to instead wrap these objects in containers, e.g. CreateTableEvent, DropTableEvent, etc. Eventually this interface will probably include onAlterTable() and onAlterPartition(), and programmers will probably want to access both the before and after versions of a Table/Partition, etc. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java < https://reviews.apache.org/r/581/#comment813 > Unrelated bugfix? trunk/metastore/src/test/org/apache/hadoop/hive/metastore/DummyListener.java < https://reviews.apache.org/r/581/#comment814 > Checkstyle. Carl On 2011-04-12 01:29:41, Ashutosh Chauhan wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/581/ ----------------------------------------------------------- (Updated 2011-04-12 01:29:41) Review request for hive, Carl Steinbach, John Sichi, and Paul Yang. Summary ------- Review request for HIVE-2038 This addresses bug HIVE-2038 . https://issues.apache.org/jira/browse/HIVE-2038 Diffs ----- trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1079575 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1079575 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreListener.java PRE-CREATION trunk/metastore/src/java/org/apache/hadoop/hive/metastore/NoOpListener.java PRE-CREATION trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 1079575 trunk/metastore/src/test/org/apache/hadoop/hive/metastore/DummyListener.java PRE-CREATION trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreListener.java PRE-CREATION Diff: https://reviews.apache.org/r/581/diff Testing ------- Unit test with dummy listener included. Also tested with an alternate listener which sends a message on a message bus. Thanks, Ashutosh
          Hide
          jiraposter@reviews.apache.org added a comment -

          On 2011-04-12 03:07:54, Carl Steinbach wrote:

          > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java, line 999

          > <https://reviews.apache.org/r/581/diff/1/?file=15625#file15625line999>

          >

          > Unrelated bugfix?

          Related bugfix, I will say : ) Without it, when drop partition returns from object store, partition object doesn't contain partition values.

          On 2011-04-12 03:07:54, Carl Steinbach wrote:

          > trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, line 180

          > <https://reviews.apache.org/r/581/diff/1/?file=15621#file15621line180>

          >

          > Please add this property to hive-default.xml along with a description of what it does.

          >

          Will add it in hive-default.xml.

          On 2011-04-12 03:07:54, Carl Steinbach wrote:

          > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, line 955

          > <https://reviews.apache.org/r/581/diff/1/?file=15622#file15622line955>

          >

          > Please run checkstyle and correct any violations included in your patch.

          Will run checkstyle to check for any style violations.

          On 2011-04-12 03:07:54, Carl Steinbach wrote:

          > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreListener.java, line 27

          > <https://reviews.apache.org/r/581/diff/1/?file=15623#file15623line27>

          >

          > Please add some javadoc explaining the intended use of this interface.

          >

          > * Are the methods called before or after an action completes? What happens if a metastore operation fails?

          >

          > * Are the methods allowed to block? Are they run in a separate thread?

          >

          > * Are the methods allowed to modify the catalog objects that are passed in as parameters?

          Will also add in javadoc.

          • Methods are called after action completes. Only if action succeeds. They are not called if operation fails since in that case nothing has actually changed in metastore.
          • This is upto implementation. They can run in same thread, or they can schedule there work in separate thread and return immediately.
          • I don't see a reason to disallow modification of passed in parameter objects. But, its mostly irrelevant here since methods are called after change has already been persisted on metastore. So, modifying these objects can't change any state on metastore.

          On 2011-04-12 03:07:54, Carl Steinbach wrote:

          > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreListener.java, line 29

          > <https://reviews.apache.org/r/581/diff/1/?file=15623#file15623line29>

          >

          > Instead of passing in raw Table/Partition/Database objects it may be better to instead wrap these objects in containers, e.g. CreateTableEvent, DropTableEvent, etc. Eventually this interface will probably include onAlterTable() and onAlterPartition(), and programmers will probably want to access both the before and after versions of a Table/Partition, etc.

          Whats the advantage of wrapper container objects?

          On 2011-04-12 03:07:54, Carl Steinbach wrote:

          > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, line 1446

          > <https://reviews.apache.org/r/581/diff/1/?file=15622#file15622line1446>

          >

          > No need to reference "this", right?

          Right. Though, I think using "this" in such cases improves code readability.

          On 2011-04-12 03:07:54, Carl Steinbach wrote:

          > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreListener.java, line 26

          > <https://reviews.apache.org/r/581/diff/1/?file=15623#file15623line26>

          >

          > What do you think about changing the name to MetaStoreEventListener or CatalogEventListener?

          MetaStoreEventListener is fine too.

          • Ashutosh

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/581/#review428
          -----------------------------------------------------------

          On 2011-04-12 01:29:41, Ashutosh Chauhan wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/581/

          -----------------------------------------------------------

          (Updated 2011-04-12 01:29:41)

          Review request for hive, Carl Steinbach, John Sichi, and Paul Yang.

          Summary

          -------

          Review request for HIVE-2038

          This addresses bug HIVE-2038.

          https://issues.apache.org/jira/browse/HIVE-2038

          Diffs

          -----

          trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1079575

          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1079575

          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreListener.java PRE-CREATION

          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/NoOpListener.java PRE-CREATION

          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 1079575

          trunk/metastore/src/test/org/apache/hadoop/hive/metastore/DummyListener.java PRE-CREATION

          trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreListener.java PRE-CREATION

          Diff: https://reviews.apache.org/r/581/diff

          Testing

          -------

          Unit test with dummy listener included. Also tested with an alternate listener which sends a message on a message bus.

          Thanks,

          Ashutosh

          Show
          jiraposter@reviews.apache.org added a comment - On 2011-04-12 03:07:54, Carl Steinbach wrote: > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java, line 999 > < https://reviews.apache.org/r/581/diff/1/?file=15625#file15625line999 > > > Unrelated bugfix? Related bugfix, I will say : ) Without it, when drop partition returns from object store, partition object doesn't contain partition values. On 2011-04-12 03:07:54, Carl Steinbach wrote: > trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, line 180 > < https://reviews.apache.org/r/581/diff/1/?file=15621#file15621line180 > > > Please add this property to hive-default.xml along with a description of what it does. > Will add it in hive-default.xml. On 2011-04-12 03:07:54, Carl Steinbach wrote: > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, line 955 > < https://reviews.apache.org/r/581/diff/1/?file=15622#file15622line955 > > > Please run checkstyle and correct any violations included in your patch. Will run checkstyle to check for any style violations. On 2011-04-12 03:07:54, Carl Steinbach wrote: > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreListener.java, line 27 > < https://reviews.apache.org/r/581/diff/1/?file=15623#file15623line27 > > > Please add some javadoc explaining the intended use of this interface. > > * Are the methods called before or after an action completes? What happens if a metastore operation fails? > > * Are the methods allowed to block? Are they run in a separate thread? > > * Are the methods allowed to modify the catalog objects that are passed in as parameters? Will also add in javadoc. Methods are called after action completes. Only if action succeeds. They are not called if operation fails since in that case nothing has actually changed in metastore. This is upto implementation. They can run in same thread, or they can schedule there work in separate thread and return immediately. I don't see a reason to disallow modification of passed in parameter objects. But, its mostly irrelevant here since methods are called after change has already been persisted on metastore. So, modifying these objects can't change any state on metastore. On 2011-04-12 03:07:54, Carl Steinbach wrote: > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreListener.java, line 29 > < https://reviews.apache.org/r/581/diff/1/?file=15623#file15623line29 > > > Instead of passing in raw Table/Partition/Database objects it may be better to instead wrap these objects in containers, e.g. CreateTableEvent, DropTableEvent, etc. Eventually this interface will probably include onAlterTable() and onAlterPartition(), and programmers will probably want to access both the before and after versions of a Table/Partition, etc. Whats the advantage of wrapper container objects? On 2011-04-12 03:07:54, Carl Steinbach wrote: > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, line 1446 > < https://reviews.apache.org/r/581/diff/1/?file=15622#file15622line1446 > > > No need to reference "this", right? Right. Though, I think using "this" in such cases improves code readability. On 2011-04-12 03:07:54, Carl Steinbach wrote: > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreListener.java, line 26 > < https://reviews.apache.org/r/581/diff/1/?file=15623#file15623line26 > > > What do you think about changing the name to MetaStoreEventListener or CatalogEventListener? MetaStoreEventListener is fine too. Ashutosh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/581/#review428 ----------------------------------------------------------- On 2011-04-12 01:29:41, Ashutosh Chauhan wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/581/ ----------------------------------------------------------- (Updated 2011-04-12 01:29:41) Review request for hive, Carl Steinbach, John Sichi, and Paul Yang. Summary ------- Review request for HIVE-2038 This addresses bug HIVE-2038 . https://issues.apache.org/jira/browse/HIVE-2038 Diffs ----- trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1079575 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1079575 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreListener.java PRE-CREATION trunk/metastore/src/java/org/apache/hadoop/hive/metastore/NoOpListener.java PRE-CREATION trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 1079575 trunk/metastore/src/test/org/apache/hadoop/hive/metastore/DummyListener.java PRE-CREATION trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreListener.java PRE-CREATION Diff: https://reviews.apache.org/r/581/diff Testing ------- Unit test with dummy listener included. Also tested with an alternate listener which sends a message on a message bus. Thanks, Ashutosh
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/606/
          -----------------------------------------------------------

          Review request for Carl Steinbach.

          Summary
          -------

          Addressed Carl's comments.

          This addresses bug HIVE-2038.
          https://issues.apache.org/jira/browse/HIVE-2038

          Diffs


          trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1092811
          trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 1092811
          trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 1092811
          trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 1092811
          trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 1092811
          trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 1092811
          trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1092811
          trunk/conf/hive-default.xml 1092811
          trunk/metastore/if/hive_metastore.thrift 1092811
          trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1092811
          trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1092811
          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1092811
          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1092811
          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 1092811
          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 1092811
          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 1092811

          Diff: https://reviews.apache.org/r/606/diff

          Testing
          -------

          Thanks,

          Ashutosh

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/606/ ----------------------------------------------------------- Review request for Carl Steinbach. Summary ------- Addressed Carl's comments. This addresses bug HIVE-2038 . https://issues.apache.org/jira/browse/HIVE-2038 Diffs trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1092811 trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 1092811 trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 1092811 trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 1092811 trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 1092811 trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 1092811 trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1092811 trunk/conf/hive-default.xml 1092811 trunk/metastore/if/hive_metastore.thrift 1092811 trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1092811 trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1092811 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1092811 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1092811 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 1092811 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 1092811 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 1092811 Diff: https://reviews.apache.org/r/606/diff Testing ------- Thanks, Ashutosh
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/618/
          -----------------------------------------------------------

          Review request for hive and Carl Steinbach.

          Summary
          -------

          Addresses Carl's comment for previous patch.
          Also added a new method finalizePartition in metastore through which metastore client can indicate to metastore that partition can be finalized.

          This addresses bug HIVE-2038.
          https://issues.apache.org/jira/browse/HIVE-2038

          Diffs


          trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1094688
          trunk/conf/hive-default.xml 1094688
          trunk/metastore/if/hive_metastore.thrift 1094688
          trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1094688
          trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1094688
          trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 1094688
          trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 1094688
          trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 1094688
          trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 1094688
          trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 1094688
          trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1094688
          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1094688
          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1094688
          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 1094688
          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java PRE-CREATION
          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 1094688
          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/NoOpListener.java PRE-CREATION
          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 1094688
          trunk/metastore/src/test/org/apache/hadoop/hive/metastore/DummyListener.java PRE-CREATION
          trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java PRE-CREATION

          Diff: https://reviews.apache.org/r/618/diff

          Testing
          -------

          Thanks,

          Ashutosh

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/618/ ----------------------------------------------------------- Review request for hive and Carl Steinbach. Summary ------- Addresses Carl's comment for previous patch. Also added a new method finalizePartition in metastore through which metastore client can indicate to metastore that partition can be finalized. This addresses bug HIVE-2038 . https://issues.apache.org/jira/browse/HIVE-2038 Diffs trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1094688 trunk/conf/hive-default.xml 1094688 trunk/metastore/if/hive_metastore.thrift 1094688 trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1094688 trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1094688 trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 1094688 trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 1094688 trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 1094688 trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 1094688 trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 1094688 trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1094688 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1094688 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1094688 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 1094688 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java PRE-CREATION trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 1094688 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/NoOpListener.java PRE-CREATION trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 1094688 trunk/metastore/src/test/org/apache/hadoop/hive/metastore/DummyListener.java PRE-CREATION trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java PRE-CREATION Diff: https://reviews.apache.org/r/618/diff Testing ------- Thanks, Ashutosh
          Hide
          Ashutosh Chauhan added a comment -

          @Carl,
          I have uploaded a new patch on reviewboard. It addresses your comments. When I run checkstyle on it, it reports huge number of problems even without my patch. It's hard to figure out which new ones are there (if any). I tried to correct all those style issues which I could find. If you find any more, it will be great if you can point those ones to me.

          Show
          Ashutosh Chauhan added a comment - @Carl, I have uploaded a new patch on reviewboard. It addresses your comments. When I run checkstyle on it, it reports huge number of problems even without my patch. It's hard to figure out which new ones are there (if any). I tried to correct all those style issues which I could find. If you find any more, it will be great if you can point those ones to me.
          Hide
          Carl Steinbach added a comment -

          @Ashutosh: I'll take a look later tonight. Thanks.

          Show
          Carl Steinbach added a comment - @Ashutosh: I'll take a look later tonight. Thanks.
          Hide
          Carl Steinbach added a comment -

          @Ashutosh: please see my comments here: https://reviews.apache.org/r/618/

          Show
          Carl Steinbach added a comment - @Ashutosh: please see my comments here: https://reviews.apache.org/r/618/
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/618/#review522
          -----------------------------------------------------------

          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
          <https://reviews.apache.org/r/618/#comment1070>

          spacing

          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
          <https://reviews.apache.org/r/618/#comment1071>

          formatting

          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
          <https://reviews.apache.org/r/618/#comment1072>

          spacing

          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
          <https://reviews.apache.org/r/618/#comment1073>

          spacing

          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
          <https://reviews.apache.org/r/618/#comment1074>

          spacing

          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java
          <https://reviews.apache.org/r/618/#comment1075>

          This change should go in a separate ticket. What does it mean to "finalize" a partition?

          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java
          <https://reviews.apache.org/r/618/#comment1076>

          spacing

          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java
          <https://reviews.apache.org/r/618/#comment1087>

          Instead of passing in raw Table/Partition/Database objects please wrap these objects in containers, e.g. CreateTableEvent, DropTableEvent, etc.

          Q: Whats the advantage of wrapper container objects?

          The advantage of container objects is that it allows us to evolve the API without breaking compatibility with older clients. With the current interface if I want to add a parameter to one of these methods I will break compatibility, but if we use container objects I can add a new field to the container without affecting older clients.

          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java
          <https://reviews.apache.org/r/618/#comment1077>

          spacing

          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java
          <https://reviews.apache.org/r/618/#comment1078>

          spacing

          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java
          <https://reviews.apache.org/r/618/#comment1079>

          spacing

          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java
          <https://reviews.apache.org/r/618/#comment1080>

          Please remove this and include it in a separate patch. We need to discuss what "finalizing" a partition actually means, and how it relates to locking.

          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java
          <https://reviews.apache.org/r/618/#comment1083>

          spacing

          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java
          <https://reviews.apache.org/r/618/#comment1082>

          spacing

          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java
          <https://reviews.apache.org/r/618/#comment1081>

          spacing

          trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java
          <https://reviews.apache.org/r/618/#comment1086>

          spacing

          • Carl

          On 2011-04-18 18:44:05, Ashutosh Chauhan wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/618/

          -----------------------------------------------------------

          (Updated 2011-04-18 18:44:05)

          Review request for hive and Carl Steinbach.

          Summary

          -------

          Addresses Carl's comment for previous patch.

          Also added a new method finalizePartition in metastore through which metastore client can indicate to metastore that partition can be finalized.

          This addresses bug HIVE-2038.

          https://issues.apache.org/jira/browse/HIVE-2038

          Diffs

          -----

          trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1094688

          trunk/conf/hive-default.xml 1094688

          trunk/metastore/if/hive_metastore.thrift 1094688

          trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1094688

          trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1094688

          trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 1094688

          trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 1094688

          trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 1094688

          trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 1094688

          trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 1094688

          trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1094688

          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1094688

          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1094688

          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 1094688

          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java PRE-CREATION

          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 1094688

          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/NoOpListener.java PRE-CREATION

          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 1094688

          trunk/metastore/src/test/org/apache/hadoop/hive/metastore/DummyListener.java PRE-CREATION

          trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java PRE-CREATION

          Diff: https://reviews.apache.org/r/618/diff

          Testing

          -------

          Thanks,

          Ashutosh

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/618/#review522 ----------------------------------------------------------- trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java < https://reviews.apache.org/r/618/#comment1070 > spacing trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java < https://reviews.apache.org/r/618/#comment1071 > formatting trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java < https://reviews.apache.org/r/618/#comment1072 > spacing trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java < https://reviews.apache.org/r/618/#comment1073 > spacing trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java < https://reviews.apache.org/r/618/#comment1074 > spacing trunk/metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java < https://reviews.apache.org/r/618/#comment1075 > This change should go in a separate ticket. What does it mean to "finalize" a partition? trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java < https://reviews.apache.org/r/618/#comment1076 > spacing trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java < https://reviews.apache.org/r/618/#comment1087 > Instead of passing in raw Table/Partition/Database objects please wrap these objects in containers, e.g. CreateTableEvent, DropTableEvent, etc. Q: Whats the advantage of wrapper container objects? The advantage of container objects is that it allows us to evolve the API without breaking compatibility with older clients. With the current interface if I want to add a parameter to one of these methods I will break compatibility, but if we use container objects I can add a new field to the container without affecting older clients. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java < https://reviews.apache.org/r/618/#comment1077 > spacing trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java < https://reviews.apache.org/r/618/#comment1078 > spacing trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java < https://reviews.apache.org/r/618/#comment1079 > spacing trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java < https://reviews.apache.org/r/618/#comment1080 > Please remove this and include it in a separate patch. We need to discuss what "finalizing" a partition actually means, and how it relates to locking. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java < https://reviews.apache.org/r/618/#comment1083 > spacing trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java < https://reviews.apache.org/r/618/#comment1082 > spacing trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java < https://reviews.apache.org/r/618/#comment1081 > spacing trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java < https://reviews.apache.org/r/618/#comment1086 > spacing Carl On 2011-04-18 18:44:05, Ashutosh Chauhan wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/618/ ----------------------------------------------------------- (Updated 2011-04-18 18:44:05) Review request for hive and Carl Steinbach. Summary ------- Addresses Carl's comment for previous patch. Also added a new method finalizePartition in metastore through which metastore client can indicate to metastore that partition can be finalized. This addresses bug HIVE-2038 . https://issues.apache.org/jira/browse/HIVE-2038 Diffs ----- trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1094688 trunk/conf/hive-default.xml 1094688 trunk/metastore/if/hive_metastore.thrift 1094688 trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1094688 trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1094688 trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 1094688 trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 1094688 trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 1094688 trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 1094688 trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 1094688 trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1094688 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1094688 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1094688 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 1094688 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java PRE-CREATION trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 1094688 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/NoOpListener.java PRE-CREATION trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 1094688 trunk/metastore/src/test/org/apache/hadoop/hive/metastore/DummyListener.java PRE-CREATION trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java PRE-CREATION Diff: https://reviews.apache.org/r/618/diff Testing ------- Thanks, Ashutosh
          Hide
          jiraposter@reviews.apache.org added a comment -

          On 2011-04-21 22:51:56, Carl Steinbach wrote:

          > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java, line 41

          > <https://reviews.apache.org/r/618/diff/1/?file=15927#file15927line41>

          >

          > Instead of passing in raw Table/Partition/Database objects please wrap these objects in containers, e.g. CreateTableEvent, DropTableEvent, etc.

          >

          > Q: Whats the advantage of wrapper container objects?

          >

          > The advantage of container objects is that it allows us to evolve the API without breaking compatibility with older clients. With the current interface if I want to add a parameter to one of these methods I will break compatibility, but if we use container objects I can add a new field to the container without affecting older clients.

          It seems like this same concern also dictates that MetaStoreListener should be an abstract class instead of an interface. Can you please make this change?

          • Carl

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/618/#review522
          -----------------------------------------------------------

          On 2011-04-18 18:44:05, Ashutosh Chauhan wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/618/

          -----------------------------------------------------------

          (Updated 2011-04-18 18:44:05)

          Review request for hive and Carl Steinbach.

          Summary

          -------

          Addresses Carl's comment for previous patch.

          Also added a new method finalizePartition in metastore through which metastore client can indicate to metastore that partition can be finalized.

          This addresses bug HIVE-2038.

          https://issues.apache.org/jira/browse/HIVE-2038

          Diffs

          -----

          trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1094688

          trunk/conf/hive-default.xml 1094688

          trunk/metastore/if/hive_metastore.thrift 1094688

          trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1094688

          trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1094688

          trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 1094688

          trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 1094688

          trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 1094688

          trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 1094688

          trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 1094688

          trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1094688

          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1094688

          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1094688

          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 1094688

          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java PRE-CREATION

          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 1094688

          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/NoOpListener.java PRE-CREATION

          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 1094688

          trunk/metastore/src/test/org/apache/hadoop/hive/metastore/DummyListener.java PRE-CREATION

          trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java PRE-CREATION

          Diff: https://reviews.apache.org/r/618/diff

          Testing

          -------

          Thanks,

          Ashutosh

          Show
          jiraposter@reviews.apache.org added a comment - On 2011-04-21 22:51:56, Carl Steinbach wrote: > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java, line 41 > < https://reviews.apache.org/r/618/diff/1/?file=15927#file15927line41 > > > Instead of passing in raw Table/Partition/Database objects please wrap these objects in containers, e.g. CreateTableEvent, DropTableEvent, etc. > > Q: Whats the advantage of wrapper container objects? > > The advantage of container objects is that it allows us to evolve the API without breaking compatibility with older clients. With the current interface if I want to add a parameter to one of these methods I will break compatibility, but if we use container objects I can add a new field to the container without affecting older clients. It seems like this same concern also dictates that MetaStoreListener should be an abstract class instead of an interface. Can you please make this change? Carl ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/618/#review522 ----------------------------------------------------------- On 2011-04-18 18:44:05, Ashutosh Chauhan wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/618/ ----------------------------------------------------------- (Updated 2011-04-18 18:44:05) Review request for hive and Carl Steinbach. Summary ------- Addresses Carl's comment for previous patch. Also added a new method finalizePartition in metastore through which metastore client can indicate to metastore that partition can be finalized. This addresses bug HIVE-2038 . https://issues.apache.org/jira/browse/HIVE-2038 Diffs ----- trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1094688 trunk/conf/hive-default.xml 1094688 trunk/metastore/if/hive_metastore.thrift 1094688 trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1094688 trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1094688 trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 1094688 trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 1094688 trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 1094688 trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 1094688 trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 1094688 trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1094688 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1094688 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1094688 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 1094688 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java PRE-CREATION trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 1094688 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/NoOpListener.java PRE-CREATION trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 1094688 trunk/metastore/src/test/org/apache/hadoop/hive/metastore/DummyListener.java PRE-CREATION trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java PRE-CREATION Diff: https://reviews.apache.org/r/618/diff Testing ------- Thanks, Ashutosh
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/618/#review526
          -----------------------------------------------------------

          trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
          <https://reviews.apache.org/r/618/#comment1090>

          I think it should be possible to specify multiple metastore listeners. Can you please make the following changes:

          • Change the name of the conf property from "hive.metastore.listener" to "hive.metastore.event.listeners" and update the description to indicate that this is a comma separated list of listener classnames.
          • Change the default value for this property to be an empty string.
          • Update the code that initializes these listeners. You can cut and paste the code that's used to initialize hive.exec.pre.hooks
          • Carl

          On 2011-04-18 18:44:05, Ashutosh Chauhan wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/618/

          -----------------------------------------------------------

          (Updated 2011-04-18 18:44:05)

          Review request for hive and Carl Steinbach.

          Summary

          -------

          Addresses Carl's comment for previous patch.

          Also added a new method finalizePartition in metastore through which metastore client can indicate to metastore that partition can be finalized.

          This addresses bug HIVE-2038.

          https://issues.apache.org/jira/browse/HIVE-2038

          Diffs

          -----

          trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1094688

          trunk/conf/hive-default.xml 1094688

          trunk/metastore/if/hive_metastore.thrift 1094688

          trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1094688

          trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1094688

          trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 1094688

          trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 1094688

          trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 1094688

          trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 1094688

          trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 1094688

          trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1094688

          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1094688

          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1094688

          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 1094688

          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java PRE-CREATION

          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 1094688

          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/NoOpListener.java PRE-CREATION

          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 1094688

          trunk/metastore/src/test/org/apache/hadoop/hive/metastore/DummyListener.java PRE-CREATION

          trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java PRE-CREATION

          Diff: https://reviews.apache.org/r/618/diff

          Testing

          -------

          Thanks,

          Ashutosh

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/618/#review526 ----------------------------------------------------------- trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java < https://reviews.apache.org/r/618/#comment1090 > I think it should be possible to specify multiple metastore listeners. Can you please make the following changes: Change the name of the conf property from "hive.metastore.listener" to "hive.metastore.event.listeners" and update the description to indicate that this is a comma separated list of listener classnames. Change the default value for this property to be an empty string. Update the code that initializes these listeners. You can cut and paste the code that's used to initialize hive.exec.pre.hooks Carl On 2011-04-18 18:44:05, Ashutosh Chauhan wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/618/ ----------------------------------------------------------- (Updated 2011-04-18 18:44:05) Review request for hive and Carl Steinbach. Summary ------- Addresses Carl's comment for previous patch. Also added a new method finalizePartition in metastore through which metastore client can indicate to metastore that partition can be finalized. This addresses bug HIVE-2038 . https://issues.apache.org/jira/browse/HIVE-2038 Diffs ----- trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1094688 trunk/conf/hive-default.xml 1094688 trunk/metastore/if/hive_metastore.thrift 1094688 trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1094688 trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1094688 trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 1094688 trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 1094688 trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 1094688 trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 1094688 trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 1094688 trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1094688 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1094688 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1094688 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 1094688 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java PRE-CREATION trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 1094688 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/NoOpListener.java PRE-CREATION trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 1094688 trunk/metastore/src/test/org/apache/hadoop/hive/metastore/DummyListener.java PRE-CREATION trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java PRE-CREATION Diff: https://reviews.apache.org/r/618/diff Testing ------- Thanks, Ashutosh
          Hide
          Ashutosh Chauhan added a comment -

          We need to discuss what "finalizing" a partition actually means, and how it relates to locking.

          Meaning of "finalizing" is not defined by MetaStore but by listener hook. It is left to listener to take whatever action it thinks is appropriate. I didn't get your concern w.r.t locking. Can you explain what you are thinking here w.r.t locking?

          Show
          Ashutosh Chauhan added a comment - We need to discuss what "finalizing" a partition actually means, and how it relates to locking. Meaning of "finalizing" is not defined by MetaStore but by listener hook. It is left to listener to take whatever action it thinks is appropriate. I didn't get your concern w.r.t locking. Can you explain what you are thinking here w.r.t locking?
          Hide
          Carl Steinbach added a comment -

          I think the meaning of "finalizing" a partition is actually defined by the metastore client, since it's the client that has to call finalizePartition(). But when is the client supposed to call this? What happens if you have multiple listeners registered which each has a different idea of what it means to finalize a partition? I think the main problem with this is that the name of the method gives the impression that this is somehow well defined, when in fact the definition is left completely up to the application.

          It sounds like what you actually want is a mechanism that allows the metastore client to send application specific events to metastore listeners. Is this accurate?

          Show
          Carl Steinbach added a comment - I think the meaning of "finalizing" a partition is actually defined by the metastore client, since it's the client that has to call finalizePartition(). But when is the client supposed to call this? What happens if you have multiple listeners registered which each has a different idea of what it means to finalize a partition? I think the main problem with this is that the name of the method gives the impression that this is somehow well defined, when in fact the definition is left completely up to the application. It sounds like what you actually want is a mechanism that allows the metastore client to send application specific events to metastore listeners. Is this accurate?
          Hide
          Ashutosh Chauhan added a comment -

          Ya, you are accurate. A mechanism for metastore client to send application specific event to metastore listener. I agree "finalize" may not be an appropriate choice here. Can't think of anything better. Any suggestions : )

          Show
          Ashutosh Chauhan added a comment - Ya, you are accurate. A mechanism for metastore client to send application specific event to metastore listener. I agree "finalize" may not be an appropriate choice here. Can't think of anything better. Any suggestions : )
          Hide
          Ashutosh Chauhan added a comment -

          Shall we call it takeActionOnPartition() ? Too verbose ?

          Show
          Ashutosh Chauhan added a comment - Shall we call it takeActionOnPartition() ? Too verbose ?
          Hide
          Carl Steinbach added a comment -

          If you do it this way I think you can only support registering a single listener. This follows from the fact that the meaning of a takeActionOnPartition() event is specific to a particular application, but the listener has no way of knowing which application fired the event. I don't think this is an acceptable limitation.

          You can get around this by defining a ListenerEvent base class that third-party applications are allowed to extend. Applications can then fire this event from the client side, and listeners can register events that they are interested in listening for using an event type registry. Getting this to work is further complicated by the fact that you have to support serialization of the event objects over the Thrift interface.

          I think it's appropriate to tackle this problem in a separate JIRA. I'd like to see some concrete use cases and discuss alternatives. I'm not convinced that the MetastoreClient/MetastoreListener should support the ability to fire arbitrary events.

          Show
          Carl Steinbach added a comment - If you do it this way I think you can only support registering a single listener. This follows from the fact that the meaning of a takeActionOnPartition() event is specific to a particular application, but the listener has no way of knowing which application fired the event. I don't think this is an acceptable limitation. You can get around this by defining a ListenerEvent base class that third-party applications are allowed to extend. Applications can then fire this event from the client side, and listeners can register events that they are interested in listening for using an event type registry. Getting this to work is further complicated by the fact that you have to support serialization of the event objects over the Thrift interface. I think it's appropriate to tackle this problem in a separate JIRA. I'd like to see some concrete use cases and discuss alternatives. I'm not convinced that the MetastoreClient/MetastoreListener should support the ability to fire arbitrary events.
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/648/
          -----------------------------------------------------------

          Review request for hive and Carl Steinbach.

          Summary
          -------

          1. Removed finalizePartition(). Will file separate jira for it.
          2. Added container objects for different event types.
          3. Changed MetaStoreEventListener from interface to abstract class.
          4. Modifications to allow a list of listeners instead of just one.

          This addresses bug HIVE-2038.
          https://issues.apache.org/jira/browse/HIVE-2038

          Diffs


          trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1096112
          trunk/conf/hive-default.xml 1096112
          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1096112
          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java PRE-CREATION
          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 1096112
          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 1096112
          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/AddPartitionEvent.java PRE-CREATION
          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/CreateDatabaseEvent.java PRE-CREATION
          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/CreateTableEvent.java PRE-CREATION
          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/DropDatabaseEvent.java PRE-CREATION
          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/DropPartitionEvent.java PRE-CREATION
          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/DropTableEvent.java PRE-CREATION
          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/ListenerEvent.java PRE-CREATION
          trunk/metastore/src/test/org/apache/hadoop/hive/metastore/DummyListener.java PRE-CREATION
          trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java PRE-CREATION

          Diff: https://reviews.apache.org/r/648/diff

          Testing
          -------

          Thanks,

          Ashutosh

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/648/ ----------------------------------------------------------- Review request for hive and Carl Steinbach. Summary ------- 1. Removed finalizePartition(). Will file separate jira for it. 2. Added container objects for different event types. 3. Changed MetaStoreEventListener from interface to abstract class. 4. Modifications to allow a list of listeners instead of just one. This addresses bug HIVE-2038 . https://issues.apache.org/jira/browse/HIVE-2038 Diffs trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1096112 trunk/conf/hive-default.xml 1096112 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1096112 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java PRE-CREATION trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 1096112 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 1096112 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/AddPartitionEvent.java PRE-CREATION trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/CreateDatabaseEvent.java PRE-CREATION trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/CreateTableEvent.java PRE-CREATION trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/DropDatabaseEvent.java PRE-CREATION trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/DropPartitionEvent.java PRE-CREATION trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/DropTableEvent.java PRE-CREATION trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/ListenerEvent.java PRE-CREATION trunk/metastore/src/test/org/apache/hadoop/hive/metastore/DummyListener.java PRE-CREATION trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java PRE-CREATION Diff: https://reviews.apache.org/r/648/diff Testing ------- Thanks, Ashutosh
          Hide
          Ashutosh Chauhan added a comment -

          This is identical patch to the one on ReviewBoard with only diff being listeners are now instantiated with constructors which takes conf as parameter.

          Show
          Ashutosh Chauhan added a comment - This is identical patch to the one on ReviewBoard with only diff being listeners are now instantiated with constructors which takes conf as parameter.
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/648/
          -----------------------------------------------------------

          (Updated 2011-04-27 18:32:08.932517)

          Review request for hive and Carl Steinbach.

          Changes
          -------

          Identical patch on jira.

          Summary
          -------

          1. Removed finalizePartition(). Will file separate jira for it.
          2. Added container objects for different event types.
          3. Changed MetaStoreEventListener from interface to abstract class.
          4. Modifications to allow a list of listeners instead of just one.

          This addresses bug HIVE-2038.
          https://issues.apache.org/jira/browse/HIVE-2038

          Diffs (updated)


          trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1096112
          trunk/conf/hive-default.xml 1096112
          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1096112
          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java PRE-CREATION
          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 1096112
          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 1096112
          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/AddPartitionEvent.java PRE-CREATION
          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/CreateDatabaseEvent.java PRE-CREATION
          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/CreateTableEvent.java PRE-CREATION
          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/DropDatabaseEvent.java PRE-CREATION
          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/DropPartitionEvent.java PRE-CREATION
          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/DropTableEvent.java PRE-CREATION
          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/ListenerEvent.java PRE-CREATION
          trunk/metastore/src/test/org/apache/hadoop/hive/metastore/DummyListener.java PRE-CREATION
          trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java PRE-CREATION

          Diff: https://reviews.apache.org/r/648/diff

          Testing
          -------

          Thanks,

          Ashutosh

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/648/ ----------------------------------------------------------- (Updated 2011-04-27 18:32:08.932517) Review request for hive and Carl Steinbach. Changes ------- Identical patch on jira. Summary ------- 1. Removed finalizePartition(). Will file separate jira for it. 2. Added container objects for different event types. 3. Changed MetaStoreEventListener from interface to abstract class. 4. Modifications to allow a list of listeners instead of just one. This addresses bug HIVE-2038 . https://issues.apache.org/jira/browse/HIVE-2038 Diffs (updated) trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1096112 trunk/conf/hive-default.xml 1096112 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1096112 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java PRE-CREATION trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 1096112 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 1096112 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/AddPartitionEvent.java PRE-CREATION trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/CreateDatabaseEvent.java PRE-CREATION trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/CreateTableEvent.java PRE-CREATION trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/DropDatabaseEvent.java PRE-CREATION trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/DropPartitionEvent.java PRE-CREATION trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/DropTableEvent.java PRE-CREATION trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/ListenerEvent.java PRE-CREATION trunk/metastore/src/test/org/apache/hadoop/hive/metastore/DummyListener.java PRE-CREATION trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java PRE-CREATION Diff: https://reviews.apache.org/r/648/diff Testing ------- Thanks, Ashutosh
          Hide
          Carl Steinbach added a comment -

          +1. Will commit if tests pass.

          Show
          Carl Steinbach added a comment - +1. Will commit if tests pass.
          Hide
          Carl Steinbach added a comment -

          @Ashutosh: Apologies for the delay in getting this committed. I've been having problems with my test setup lately, but I think I've got the issue resolved. Expect to see this go in sometime in the next day or so.

          Show
          Carl Steinbach added a comment - @Ashutosh: Apologies for the delay in getting this committed. I've been having problems with my test setup lately, but I think I've got the issue resolved. Expect to see this go in sometime in the next day or so.
          Hide
          Ashutosh Chauhan added a comment -

          Updated patch to sync with trunk.

          Show
          Ashutosh Chauhan added a comment - Updated patch to sync with trunk.
          Hide
          Ashutosh Chauhan added a comment -

          @Carl,

          Knock knock : ) Let me know if I can be of any help here.

          Show
          Ashutosh Chauhan added a comment - @Carl, Knock knock : ) Let me know if I can be of any help here.
          Hide
          Carl Steinbach added a comment -

          @Ashutosh: I think I finally got a my build problems fixed. I haven't had a clean test run yet, but a majority of tests are now passing. I'll send out another update later today,

          Show
          Carl Steinbach added a comment - @Ashutosh: I think I finally got a my build problems fixed. I haven't had a clean test run yet, but a majority of tests are now passing. I'll send out another update later today,
          Hide
          Carl Steinbach added a comment -

          Committed to trunk. Thanks Ashutosh!

          Show
          Carl Steinbach added a comment - Committed to trunk. Thanks Ashutosh!
          Hide
          Hudson added a comment -

          Integrated in Hive-trunk-h0.20 #712 (See https://builds.apache.org/hudson/job/Hive-trunk-h0.20/712/)
          HIVE-2038. Add MetaStoreListener interface (Ashutosh Chauhan via cws)

          Show
          Hudson added a comment - Integrated in Hive-trunk-h0.20 #712 (See https://builds.apache.org/hudson/job/Hive-trunk-h0.20/712/ ) HIVE-2038 . Add MetaStoreListener interface (Ashutosh Chauhan via cws)
          Hide
          Arup Malakar added a comment -

          Ashutosh Chauhan is the MetaStoreListener implementation supposed to be threadsafe? I am seeing issues related to that in HCatalog. The javadoc of the listener interface doesn't mention anything.

          Show
          Arup Malakar added a comment - Ashutosh Chauhan is the MetaStoreListener implementation supposed to be threadsafe? I am seeing issues related to that in HCatalog. The javadoc of the listener interface doesn't mention anything.

            People

            • Assignee:
              Ashutosh Chauhan
              Reporter:
              Ashutosh Chauhan
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development