Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-20368

Remove VectorTopNKeyOperator lock

    XMLWordPrintableJSON

Details

    Description

      VectorTopNKeyOperator has a lock in line 199 as following.

      priorityQueue.offer(WritableUtils.clone(keysWritable, getConfiguration()));

      WritableUtils.clone calls Confgiruation.getClassByNameOrNull that has synchronized block. So it needs to run without locks.

      Attachments

        1. HIVE-20368.1.patch
          16 kB
          Teddy Choi
        2. HIVE-20368.2.patch
          13 kB
          Teddy Choi
        3. HIVE-20368.2.patch
          13 kB
          Teddy Choi

        Issue Links

          is depended upon by

          Improvement - An improvement or enhancement to an existing feature or task. HIVE-20150 TopNKey pushdown

          • Major - Major loss of function.
          • Closed
          relates to

          New Feature - A new feature of the product, which has yet to be developed. HIVE-17896 TopNKey: Create a standalone vectorizable TopNKey operator

          • Major - Major loss of function.
          • Closed
          links to

          Web Link GitHub Pull Request #414

          Web Link GitHub Pull Request #414

          Activity

            People

              teddy.choi Teddy Choi
              teddy.choi Teddy Choi
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 20m
                  20m