[HIVE-20191] PreCommit patch application doesn't fail if patch is empty

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 4.0.0-alpha-1
• Component/s: Testing Infrastructure
• Assignee: Daniel Voros
• Reporter: Daniel Voros
• Created: 17/Jul/18 09:39
• Updated: 17/Nov/22 08:55
• Resolved: 27/Aug/18 09:54

Description

I've created some backport tickets to branch-3 (e.g. HIVE-20181) and made the mistake of uploading the patch files with wrong filename (. instead of - between version and branch).

These get applied on master, where they're already present, since git apply with -3 won't fail if patch is already there. Tests are run on master instead of failing.

I think the patch application should fail if the patch is empty and branch selection logic should probably fail too if the patch name is malformed.