Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-20191

PreCommit patch application doesn't fail if patch is empty

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0.0
    • Component/s: Testing Infrastructure
    • Labels:
      None

      Description

      I've created some backport tickets to branch-3 (e.g. HIVE-20181) and made the mistake of uploading the patch files with wrong filename (. instead of - between version and branch).

      These get applied on master, where they're already present, since git apply with -3 won't fail if patch is already there. Tests are run on master instead of failing.

      I think the patch application should fail if the patch is empty and branch selection logic should probably fail too if the patch name is malformed.

        Attachments

        1. HIVE-20191.1.patch
          3 kB
          Daniel Voros

          Activity

            People

            • Assignee:
              dvoros Daniel Voros
              Reporter:
              dvoros Daniel Voros
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: