[HIVE-20043] HiveServer2: SessionState has a static sync block around an AtomicBoolean

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0
• Fix Version/s: 4.0.0-alpha-1
• Component/s: HiveServer2
• Labels: Branch3Candidate Concurrency
• Assignee: László Bodor
• Reporter: Gopal Vijayaraghavan
• Created: 01/Jul/18 05:59
• Updated: 17/Nov/22 08:55
• Resolved: 09/Jul/18 16:34

Description

  private static void start(SessionState startSs, boolean isAsync, LogHelper console) {
...
    synchronized(SessionState.class) {
      if (!startSs.isStarted.compareAndSet(false, true)) {
        return;
      }
    }

startSs.isStarted is an AtomicBoolean, which makes it hard to know why this code is locked with a static lock.