[HIVE-19403] Demote 'Pattern' Logging

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 2.4.0, 3.0.0
• Fix Version/s: 4.0.0-alpha-1
• Component/s: HiveServer2
• Labels: noob
• Assignee: gonglinglei
• Reporter: David Mollitor
• Created: 03/May/18 13:41
• Updated: 17/Nov/22 08:54
• Resolved: 29/Nov/18 11:29

Description

In the DDLTask class, there is some logging that is not helpful to a cluster admin and should be demoted to debug level logging. In fact, in one place in the code, it already is.

LOG.info("pattern: {}", showDatabasesDesc.getPattern());
LOG.debug("pattern: {}", pattern);
LOG.info("pattern: {}", showFuncs.getPattern());
LOG.info("pattern: {}", showTblStatus.getPattern());

Here is an example... as an admin, I can already see what the pattern is, I do not need this extra logging. It provides no additional context.

Example

2018-05-03 03:08:26,354 INFO  org.apache.hadoop.hive.ql.Driver: [HiveServer2-Background-Pool: Thread-101980]: Executing command(queryId=hive_20180503030808_e53c26ef-2280-4eca-929b-668503105e2e): SHOW TABLE EXTENDED FROM my_db LIKE '*'
2018-05-03 03:08:26,355 INFO  hive.ql.exec.DDLTask: [HiveServer2-Background-Pool: Thread-101980]: pattern: *

Issue Links

• relates to: HIVE-19404 Revise DDL Task Result Logging