Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-19403

Demote 'Pattern' Logging

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 3.0.0, 2.4.0
    • Fix Version/s: 4.0.0
    • Component/s: HiveServer2
    • Labels:

      Description

      In the DDLTask class, there is some logging that is not helpful to a cluster admin and should be demoted to debug level logging. In fact, in one place in the code, it already is.

      LOG.info("pattern: {}", showDatabasesDesc.getPattern());
      LOG.debug("pattern: {}", pattern);
      LOG.info("pattern: {}", showFuncs.getPattern());
      LOG.info("pattern: {}", showTblStatus.getPattern());
      

      Here is an example... as an admin, I can already see what the pattern is, I do not need this extra logging. It provides no additional context.

      Example
      2018-05-03 03:08:26,354 INFO  org.apache.hadoop.hive.ql.Driver: [HiveServer2-Background-Pool: Thread-101980]: Executing command(queryId=hive_20180503030808_e53c26ef-2280-4eca-929b-668503105e2e): SHOW TABLE EXTENDED FROM my_db LIKE '*'
      2018-05-03 03:08:26,355 INFO  hive.ql.exec.DDLTask: [HiveServer2-Background-Pool: Thread-101980]: pattern: *
      

        Attachments

        1. HIVE-19403.1.patch
          2 kB
          gonglinglei

          Issue Links

            Activity

              People

              • Assignee:
                gonglinglei gonglinglei
                Reporter:
                belugabehr David Mollitor
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: