[ORC-381] OutStream.write hangs with misconfigured bufferSize

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 1.5.1
• Assignee: Unassigned
• Reporter: John Doe
• Created: 03/May/18 03:53
• Updated: 22/Jun/18 21:41

Description

When the bufferSize is configured to be 0 in the class initialization, the while loop in OutStream.write function hangs endlessly.
This is because when the bufferSize is 0, current.remaining is 0, length will always > 0.
Here is the code snippet.

   OutStream(String name, int bufferSize, CompressionCodec codec, OutputReceiver receiver) throws IOException {
    ...
    this.bufferSize = bufferSize; //bufferSize can be configured with 0
    ...
  }

    private void getNewInputBuffer() throws IOException {
      ...
      current = ByteBuffer.allocate(bufferSize);
      ...
  }

  public void write(byte[] bytes, int offset, int length) throws IOException {
    if (current == null) {
      getNewInputBuffer();
    }
    int remaining = Math.min(current.remaining(), length);
    current.put(bytes, offset, remaining);
    uncompressedBytes += remaining;
    length -= remaining;
    while (length != 0) {//length > 0
      spill();
      offset += remaining;
      remaining = Math.min(current.remaining(), length);//current.remaining() == 0
      current.put(bytes, offset, remaining);
      uncompressedBytes += remaining;
      length -= remaining;
    }
  }

The similar case is HDFS-13513, HDFS-13514