[HIVE-19265] Potential NPE and hiding actual exception in Hive#copyFiles

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 4.0.0-alpha-1
• Assignee: Igor Kryvenko
• Reporter: Igor Kryvenko
• Created: 21/Apr/18 20:16
• Updated: 17/Nov/22 08:54
• Resolved: 24/Apr/18 01:53

Description

In Hive#copyFiles we have such code

if (src.isDirectory()) {
        try {
          files = srcFs.listStatus(src.getPath(), FileUtils.HIDDEN_FILES_PATH_FILTER);
        } catch (IOException e) {
          pool.shutdownNow();
          throw new HiveException(e);
        }
      }

If pool is null we will get NPE and actual cause will be lost.

Initializing of pool

    final ExecutorService pool = conf.getInt(ConfVars.HIVE_MOVE_FILES_THREAD_COUNT.varname, 25) > 0 ?
        Executors.newFixedThreadPool(conf.getInt(ConfVars.HIVE_MOVE_FILES_THREAD_COUNT.varname, 25),
        new ThreadFactoryBuilder().setDaemon(true).setNameFormat("Move-Thread-%d").build()) : null;

So in the case when the pool is not created we can get potential NPE and swallow an actual exception