[HIVE-19203] Thread-Safety Issue in HiveMetaStore

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.0.0
• Fix Version/s: 4.0.0-alpha-1
• Component/s: Metastore
• Assignee: Alice Fan
• Reporter: David Mollitor
• Created: 13/Apr/18 13:56
• Updated: 17/Nov/22 08:55
• Resolved: 12/Jun/18 22:32

Description

https://github.com/apache/hive/blob/550d1e1196b7c801c572092db974a459aac6c249/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java#L345-L351

private static int nextSerialNum = 0;
private static ThreadLocal<Integer> threadLocalId = new ThreadLocal<Integer>() {
  @Override
  protected Integer initialValue() {
    return nextSerialNum++;
  }
};

 

nextSerialNum needs to be an atomic value.