[HIVE-19158] Fix NPE in the HiveMetastore add partition tests - ASF JIRA

XML

Word

Printable

JSON

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: None
Fix Version/s: 4.0.0-alpha-1
Component/s: Metastore, Test
Labels:
None

Description

The TestAddPartitions and TestAddPartitionsFromPartSpec tests revealed that NPE is thrown in some cases. These NPEs could be prevented with a simple null check and a MetaException with a proper error message should be thrown instead.
Example: NPE is thrown in the following test cases

TestAddPartitions
- testAddPartitionNullPartition
- testAddPartitionNullValue
- testAddPartitionsNullList
TestAddPartitionsFromPartSpec
- testAddPartitionSpecNullSpec
- testAddPartitionSpecNullPartList
- testAddPartitionSpecNoDB
- testAddPartitionSpecNoTable
- testAddPartitionSpecNoDBAndTableInPartition
- testAddPartitionSpecNullPart
- testAddPartitionSpecChangeRootPathToNull
- testAddPartitionSpecWithSharedSDNullSd
- testAddPartitionSpecWithSharedSDNoValue
- testAddPartitionSpecNullValue

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending

HIVE-19158.1.patch
13/Apr/18 09:26
28 kB
Marta Kuczora
HIVE-19158.2.patch
17/Apr/18 12:34
28 kB
Marta Kuczora
HIVE-19158.3.patch
19/Apr/18 10:13
28 kB
Marta Kuczora

Activity

People

Assignee:: Marta Kuczora

Reporter:: Marta Kuczora

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 10/Apr/18 21:47

Updated:: 17/Nov/22 08:54

Resolved:: 19/Apr/18 16:18