[HIVE-19106] Hive ZooKeeper Locking - Throw and Log

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 2.3.2, 3.0.0
• Fix Version/s: 4.0.0-alpha-1
• Component/s: Locking
• Labels: noob
• Assignee: Igor Kryvenko
• Reporter: David Mollitor
• Created: 04/Apr/18 15:12
• Updated: 17/Nov/22 08:55
• Resolved: 14/Apr/18 17:10

Description

...
      } catch (Exception e) {
        if (tryNum >= numRetriesForUnLock) {
          String name = ((ZooKeeperHiveLock)hiveLock).getPath();
          LOG.error("Node " + name + " can not be deleted after " + numRetriesForUnLock + " attempts.");
          throw new LockException(e);
        }
      }

Do not log and throw. Only throw and move the message into the LockException. There is already error level logging up the stack.

https://github.com/apache/hive/blob/6d890faf22fd1ede3658a5eed097476eab3c67e9/ql/src/java/org/apache/hadoop/hive/ql/lockmgr/zookeeper/ZooKeeperHiveLockManager.java#L492-L495

Issue Links

• relates to: HIVE-18878 Lower MoveTask Lock Logging to Debug