[HIVE-18829] Inputs/Outputs are not propagated to SA hooks for explain commands.

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 2.1.1
• Component/s: HiveServer2
• Assignee: Naveen Gangam
• Reporter: Naveen Gangam
• Created: 28/Feb/18 23:20
• Updated: 28/Feb/18 23:52
• Resolved: 28/Feb/18 23:52

Description

With Sentry enabled, commands like explain drop table foo fail with

explain drop table foo;
Error: Error while compiling statement: FAILED: SemanticException No valid privileges
 Required privilege( Table) not available in input privileges
 The required privileges: (state=42000,code=40000)

Sentry fails to authorize because the ExplainSemanticAnalyzer uses an instance of DDLSemanticAnalyzer to analyze the explain query.

BaseSemanticAnalyzer sem = SemanticAnalyzerFactory.get(conf, input);
sem.analyze(input, ctx);
sem.validate()

The inputs/outputs entities for this query are set in the above code. However, these are never set on the instance of ExplainSemanticAnalyzer itself and thus is not propagated into the HookContext in the calling Driver code.

sem.analyze(tree, ctx); --> this results in calling the above code that uses DDLSA
hookCtx.update(sem); --> sem is an instance of ExplainSemanticAnalyzer, this code attempts to update the HookContext with the input/output info from ESA which is never set.

Issue Links

• duplicates: HIVE-18778 Needs to capture input/output entities in explain