[HIVE-18625] SessionState Not Checking For Directory Creation Result

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.3.2, 2.4.0, 3.0.0
• Fix Version/s: 3.0.0
• Component/s: HiveServer2
• Assignee: Andrew Sherman
• Reporter: David Mollitor
• Created: 05/Feb/18 18:41
• Updated: 22/May/18 23:15
• Resolved: 20/Feb/18 19:29

Description

https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java#L773

  private static void createPath(HiveConf conf, Path path, String permission, boolean isLocal,
      boolean isCleanUp) throws IOException {
    FsPermission fsPermission = new FsPermission(permission);
    FileSystem fs;
    if (isLocal) {
      fs = FileSystem.getLocal(conf);
    } else {
      fs = path.getFileSystem(conf);
    }
    if (!fs.exists(path)) {
      fs.mkdirs(path, fsPermission);
      String dirType = isLocal ? "local" : "HDFS";
      LOG.info("Created " + dirType + " directory: " + path.toString());
    }
    if (isCleanUp) {
      fs.deleteOnExit(path);
    }
  }

The method fs.mkdirs(path, fsPermission) returns a boolean value indicating if the directory creation was successful or not. Hive ignores this return value and therefore could be acting on a directory that doesn't exist.

Please capture the result, check it, and throw an Exception if it failed