[HIVE-18127] Do not strip '--' comments from shell commands issued from CliDriver

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.0.0
• Assignee: Andrew Sherman
• Reporter: Andrew Sherman
• Created: 22/Nov/17 01:25
• Updated: 22/May/18 23:17
• Resolved: 01/Dec/17 17:41

Description

CLiDriver has the ability to run shell commands by prefixing them with '!".
This behavior is not widely used (there are only 3 examples in .q files).
Since HIVE-16935 started stripping comments starting with '--', a shell command containing '--' will not work correctly.
Fix this by using the unstripped command for shell commands.
Note that it would be a security hole for HS2 to allow execution of arbitrary shell commands from a client command.
Add tests to nail down correct behavior with '--' comments:

• CliDriver should not strip strings starting with '--' in a shell command (FIXED in this change).
• HiveCli should strip '--' comments.
• A Jdbc program should allow commands starting with "!" but these will fail in the sql parser.

Issue Links

• is broken by: HIVE-16935 Hive should strip comments from input before choosing which CommandProcessor to run.