Affects Version/s: None
Fix Version/s: 3.0.0
CLiDriver has the ability to run shell commands by prefixing them with '!".
This behavior is not widely used (there are only 3 examples in .q files).
HIVE-16935 started stripping comments starting with '--', a shell command containing '--' will not work correctly.
Fix this by using the unstripped command for shell commands.
Note that it would be a security hole for HS2 to allow execution of arbitrary shell commands from a client command.
Add tests to nail down correct behavior with '--' comments:
- CliDriver should not strip strings starting with '--' in a shell command (FIXED in this change).
- HiveCli should strip '--' comments.
- A Jdbc program should allow commands starting with "!" but these will fail in the sql parser.