Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-18127

Do not strip '--' comments from shell commands issued from CliDriver

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0
    • Component/s: None
    • Labels:
      None

      Description

      CLiDriver has the ability to run shell commands by prefixing them with '!".
      This behavior is not widely used (there are only 3 examples in .q files).
      Since HIVE-16935 started stripping comments starting with '--', a shell command containing '--' will not work correctly.
      Fix this by using the unstripped command for shell commands.
      Note that it would be a security hole for HS2 to allow execution of arbitrary shell commands from a client command.
      Add tests to nail down correct behavior with '--' comments:

      • CliDriver should not strip strings starting with '--' in a shell command (FIXED in this change).
      • HiveCli should strip '--' comments.
      • A Jdbc program should allow commands starting with "!" but these will fail in the sql parser.

        Attachments

        1. HIVE-18127.2.patch
          6 kB
          Andrew Sherman
        2. HIVE-18127.1.patch
          6 kB
          Andrew Sherman

          Issue Links

            Activity

              People

              • Assignee:
                asherman Andrew Sherman
                Reporter:
                asherman Andrew Sherman
              • Votes:
                1 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: