[HIVE-17953] Metrics should move to destination atomically

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 3.0.0
• Fix Version/s: 3.0.0
• Component/s: Hive
• Target Version/s: 3.0.0
• Assignee: Alex Kolbasov
• Reporter: Alex Kolbasov
• Created: 01/Nov/17 00:47
• Updated: 22/May/18 23:14
• Resolved: 06/Nov/17 20:51

Description

HIVE-17563 reimplemented metrics using native nio interfaces. It used the assumption that{{Files.move()}} is atomic operation. It turns out that by default it isn't, unless ATOMIC_MOVE option is specified. Otherwise the destination file is unlinked and then the source file is copied.

This may cause test failure since the file may be temporarily unavailable.

Issue Links

• is related to: SENTRY-2035 Metrics should move to destination atomically
• links to: Code review