Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-17563

CodahaleMetrics.JsonFileReporter is not updating hive.service.metrics.file.location

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 3.0.0
    • None
    • None

    Description

      The JsonFileReporter has a bug where it never updates the content of hive.service.metrics.file.location. The original implementation relied on fs.rename to overwrite the file if it already existed, but after HIVE-13705 fs.rename now returns false if the destination file exists.

      Also, there is no reason for the JsonFileReporter to write to any fs besides the local filesystem, so we should make this local fs specific.

      Attachments

        1. HIVE-17563.01.patch
          29 kB
          Alex Kolbasov

        Issue Links

          is broken by

          Bug - A problem which impairs or prevents the functions of the product. HIVE-13705 Insert into table removes existing data

          • Major - Major loss of function.
          • Closed
          is related to

          Improvement - An improvement or enhancement to an existing feature or task. SENTRY-1963 Sentry JSON reporter should use regular implementation for local file system

          • Major - Major loss of function.
          • Resolved
          relates to

          Bug - A problem which impairs or prevents the functions of the product. HDFS-10385 LocalFileSystem rename() function should return false when destination file exists

          • Major - Major loss of function.
          • Resolved
          links to

          Web Link Code review

          Activity

            People

              akolb Alex Kolbasov
              stakiar Sahil Takiar
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: