[HIVE-17510] Make comparison of filter predicates in q files deterministic

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0
• Fix Version/s: 3.0.0
• Component/s: Testing Infrastructure
• Target Version/s: 3.0.0
• Assignee: Jesús Camacho Rodríguez
• Reporter: Jesús Camacho Rodríguez
• Created: 12/Sep/17 00:22
• Updated: 27/Feb/24 22:24
• Resolved: 20/Sep/17 19:39

Description

I have been hitting this issue while submitting patches to test HIVE-17432.

Basically, the order on which the rewriting might create the children of AND operations is not deterministic. Thus, tests might fail because the created golden file is not the same, thought the test should pass because they just simply do not follow same order:

predicate: ((d_year >= 1992) and (d_year <= 1997) and ((c_city = 'UNITED KI1') or (c_city = 'UNITED KI5')) and ((s_city = 'UNITED KI1') or (s_city = 'UNITED KI5'))) (type: boolean)

predicate: ((d_year <= 1997) and (d_year >= 1992) and ((c_city = 'UNITED KI1') or (c_city = 'UNITED KI5')) and ((s_city = 'UNITED KI1') or (s_city = 'UNITED KI5'))) (type: boolean)

This patches fixes the issue by sorting the children of some expressions (currently AND and OR children) when we run explain plan and we are running in test mode.

Issue Links

• blocks: HIVE-17432 Enable join and aggregate materialized view rewriting
• links to: RB link