[HIVE-17069] Refactor OrcRawRecrodMerger.ReaderPair

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0
• Fix Version/s: 3.0.0
• Component/s: Transactions
• Target Version/s: 3.0.0
• Assignee: Eugene Koifman
• Reporter: Eugene Koifman
• Created: 10/Jul/17 21:13
• Updated: 23/May/18 00:00
• Resolved: 18/Jul/17 17:38

Description

this should be done post HIVE-16177 so as not to obscure the functional changes completely

Make ReaderPair an interface
ReaderPairImpl - will do what ReaderPair currently does, i.e. handle "normal" code path
OriginalReaderPair - same as now but w/o incomprehensible override/variable shadowing logic.
Perhaps split it into 2 - 1 for compaction 1 for "normal" read with common base class.

Push discoverKeyBounds() into appropriate implementation

Issue Links

• is blocked by: HIVE-16177 non Acid to acid conversion doesn't handle _copy_N files