[HIVE-16424] Decimal: Non-null HiveDecimalWritables can contain NULL decimals

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 1.2.2, 2.1.1, 3.0.0
• Component/s: Types
• Target Version/s: 3.0.0
• Assignee: Unassigned
• Reporter: Gopal Vijayaraghavan
• Created: 12/Apr/17 11:01
• Updated: 12/Apr/17 11:01

Description

  public static void writeToByteStream(RandomAccessOutput byteStream,
                                       HiveDecimalWritable decWritable) {
    LazyBinaryUtils.writeVInt(byteStream, decWritable.scale());

    // NOTE: This writes into a scratch buffer within HiveDecimalWritable.
    //
    int byteLength = decWritable.bigIntegerBytesInternalScratch();

    LazyBinaryUtils.writeVInt(byteStream, byteLength);
    byteStream.write(decWritable.bigIntegerBytesInternalScratchBuffer(), 0, byteLength);
  }

Can end up writing 0 bytes as byteLength since a non-null HiveDecimalWritable does not mean a non-null HiveDecimal is contained inside it.