[HIVE-16213] ObjectStore can leak Queries when rollbackTransaction throws an exception

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.3.2, 2.4.0, 3.0.0
• Component/s: Hive
• Assignee: Vihang Karajgaonkar
• Reporter: Alex Kolbasov
• Created: 14/Mar/17 22:06
• Updated: 23/May/18 00:00
• Resolved: 02/May/17 15:34

Description

In ObjectStore.java there are a few places with the code similar to:

    Query query = null;
    try {
      openTransaction();
      query = pm.newQuery(Something.class);
      ...
      commited = commitTransaction();
    } finally {
      if (!commited) {
        rollbackTransaction();
      }
      if (query != null) {
        query.closeAll();
      }
    }

The problem is that rollbackTransaction() may throw an exception in which case query.closeAll() wouldn't be executed.

The fix would be to wrap rollbackTransaction in its own try-catch block.

Issue Links

• is related to: HIVE-17730 Queries can be closed automatically