Description
Hive metrics code currently allows pluggable metrics handlers - ie, handlers that take care of providing interfaces for metrics collection as well as a reporting; one of the 'handlers' is CodahaleMetrics. Codahale can work with different reporters - currently supported ones are Console, JMX, JSON file and hadoop2 sink. However, adding a new reporter involves changing that class. We would like to make this conf driven just the way MetricsFactory handles configurable Metrics classes.
Scope of work:
- Provide a new configuration option, HIVE_CODAHALE_REPORTER_CLASSES that enumerates classes (like HIVE_METRICS_CLASS and unlike HIVE_METRICS_REPORTER).
- Move JsonFileReporter into its own class.
- Update CodahaleMetrics.java to read new config option and if the new option is not present, look for the old option and instantiate accordingly) - ie, make the code backward compatible.
- Update and add new tests.
Attachments
Attachments
Issue Links
- relates to
-
HIVE-16393 Fix visibility of CodahaleReporter interface
- Closed
- links to