[HIVE-15168] Flaky test: TestSparkClient.testJobSubmission (still flaky)

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.3.0
• Assignee: Barna Zsombor Klara
• Reporter: Barna Zsombor Klara
• Created: 09/Nov/16 09:51
• Updated: 21/Jul/17 18:26
• Resolved: 25/Nov/16 02:53

Description

HIVE-14910 already addressed one source of flakyness bud sadly not all it seems.
In JobHandleImpl the listeners are registered after the job has been submitted.
This may end up in a racecondition.

 // Link the RPC and the promise so that events from one are propagated to the other as
      // needed.
      rpc.addListener(new GenericFutureListener<io.netty.util.concurrent.Future<Void>>() {
        @Override
        public void operationComplete(io.netty.util.concurrent.Future<Void> f) {
          if (f.isSuccess()) {
            handle.changeState(JobHandle.State.QUEUED);
          } else if (!promise.isDone()) {
            promise.setFailure(f.cause());
          }
        }
      });
      promise.addListener(new GenericFutureListener<Promise<T>>() {
        @Override
        public void operationComplete(Promise<T> p) {
          if (jobId != null) {
            jobs.remove(jobId);
          }
          if (p.isCancelled() && !rpc.isDone()) {
            rpc.cancel(true);
          }
        }
      });

Issue Links

• is related to: HIVE-14910 Flaky test: TestSparkClient.testJobSubmission
• links to: Review Board