Hive
  1. Hive
  2. HIVE-1515

archive is not working when multiple partitions inside one table are archived.

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 0.7.0
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      set hive.exec.compress.output = true;
      set hive.input.format=org.apache.hadoop.hive.ql.io.CombineHiveInputFormat;
      set mapred.min.split.size=256;
      set mapred.min.split.size.per.node=256;
      set mapred.min.split.size.per.rack=256;
      set mapred.max.split.size=256;

      set hive.archive.enabled = true;

      drop table combine_3_srcpart_seq_rc;

      create table combine_3_srcpart_seq_rc (key int , value string) partitioned by (ds string, hr string) stored as sequencefile;

      insert overwrite table combine_3_srcpart_seq_rc partition (ds="2010-08-03", hr="00") select * from src;

      insert overwrite table combine_3_srcpart_seq_rc partition (ds="2010-08-03", hr="001") select * from src;

      ALTER TABLE combine_3_srcpart_seq_rc ARCHIVE PARTITION (ds="2010-08-03", hr="00");
      ALTER TABLE combine_3_srcpart_seq_rc ARCHIVE PARTITION (ds="2010-08-03", hr="001");

      select key, value, ds, hr from combine_3_srcpart_seq_rc where ds="2010-08-03" order by key, hr limit 30;

      drop table combine_3_srcpart_seq_rc;

      will fail.

      java.io.IOException: Invalid file name: har:/data/users/heyongqiang/hive-trunk-clean/build/ql/test/data/warehouse/combine_3_srcpart_seq_rc/ds=2010-08-03/hr=001/data.har/data/users/heyongqiang/hive-trunk-clean/build/ql/test/data/warehouse/combine_3_srcpart_seq_rc/ds=2010-08-03/hr=001 in har:/data/users/heyongqiang/hive-trunk-clean/build/ql/test/data/warehouse/combine_3_srcpart_seq_rc/ds=2010-08-03/hr=00/data.har

      The reason it fails is because:
      there are 2 input paths (one for each partition) for the above query:
      1): har:/Users/heyongqiang/Documents/workspace/Hive-Index/build/ql/test/data/warehouse/combine_3_srcpart_seq_rc/ds=2010-08-03/hr=00/data.har/Users/heyongqiang/Documents/workspace/Hive-Index/build/ql/test/data/warehouse/combine_3_srcpart_seq_rc/ds=2010-08-03/hr=00
      2): har:/Users/heyongqiang/Documents/workspace/Hive-Index/build/ql/test/data/warehouse/combine_3_srcpart_seq_rc/ds=2010-08-03/hr=001/data.har/Users/heyongqiang/Documents/workspace/Hive-Index/build/ql/test/data/warehouse/combine_3_srcpart_seq_rc/ds=2010-08-03/hr=001
      But when doing path.getFileSystem() for these 2 input paths. they both return same one file system instance which points the first caller, in this case which is har:/Users/heyongqiang/Documents/workspace/Hive-Index/build/ql/test/data/warehouse/combine_3_srcpart_seq_rc/ds=2010-08-03/hr=00/data.har

      The reason here is Hadoop's FileSystem has a global cache, and when trying to load a FileSystem instance from a given path, it only take the path's scheme and username to lookup the cache. So when we do Path.getFileSystem for the second har path, it actually returns the file system handle for the first path.

      1. hive-1515.2.patch
        7 kB
        He Yongqiang
      2. hive-1515.1.patch
        10 kB
        He Yongqiang

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        3d 19h 3m 1 He Yongqiang 10/Aug/10 02:00
        Patch Available Patch Available Open Open
        2d 9m 1 Paul Yang 12/Aug/10 02:09
        He Yongqiang made changes -
        Assignee He Yongqiang [ he yongqiang ]
        He Yongqiang made changes -
        Attachment hive-1515.2.patch [ 12451974 ]
        Hide
        He Yongqiang added a comment -

        Attache a possible fix.

        Talked with Namit and Paul this afternoon about this issue. Actually there is config which can disable FileSystem cache: fs.%s.impl.disable.cache . where %s is the filesystem schema, for archive, it's har.

        So if you set "fs.har.impl.disable.cache" to false, the archive will automatically work. This should be the clean way to fix this issue.
        In order to do this, you need to apply https://issues.apache.org/jira/browse/HADOOP-6231 if your hadoop does not include the code to disable FileSystem cache.

        Show
        He Yongqiang added a comment - Attache a possible fix. Talked with Namit and Paul this afternoon about this issue. Actually there is config which can disable FileSystem cache: fs.%s.impl.disable.cache . where %s is the filesystem schema, for archive, it's har. So if you set "fs.har.impl.disable.cache" to false, the archive will automatically work. This should be the clean way to fix this issue. In order to do this, you need to apply https://issues.apache.org/jira/browse/HADOOP-6231 if your hadoop does not include the code to disable FileSystem cache.
        Hide
        HBase Review Board added a comment -

        Message from: "Paul Yang" <pyang@facebook.com>

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        http://review.cloudera.org/r/598/#review853
        -----------------------------------------------------------

        Talked to Yongqiang offline about this one. The way that this patch attempts to fix the caching issue is to append some path information to the host so that we create a new HAR filesystem instance for different HAR files. The way that this is implemented now, a "" and path information in added to the host e.g. har://hdfs-localhost-userwarehousemytable:50030... if the original were har://hdfs-localhost:50030. However, the HAR filesystem does not ignore the stuff after the second "" and so has errors when trying to connect to the underlying filesystem. A possible fix would be to modify HiveHarFileSystem to extend the initialize() method so that the characters after the second "-" is ignored.

        • Paul
        Show
        HBase Review Board added a comment - Message from: "Paul Yang" <pyang@facebook.com> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/598/#review853 ----------------------------------------------------------- Talked to Yongqiang offline about this one. The way that this patch attempts to fix the caching issue is to append some path information to the host so that we create a new HAR filesystem instance for different HAR files. The way that this is implemented now, a " " and path information in added to the host e.g. har://hdfs-localhost-user warehouse mytable:50030... if the original were har://hdfs-localhost:50030. However, the HAR filesystem does not ignore the stuff after the second " " and so has errors when trying to connect to the underlying filesystem. A possible fix would be to modify HiveHarFileSystem to extend the initialize() method so that the characters after the second "-" is ignored. Paul
        Paul Yang made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Hide
        Paul Yang added a comment -

        See comments on reviewboard.

        Show
        Paul Yang added a comment - See comments on reviewboard.
        He Yongqiang made changes -
        Attachment hive-1515.2.patch [ 12451690 ]
        He Yongqiang made changes -
        Attachment hive-1515.2.patch [ 12451690 ]
        Hide
        HBase Review Board added a comment -

        Message from: "Yongqiang He" <heyongqiangict@gmail.com>

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        http://review.cloudera.org/r/598/
        -----------------------------------------------------------

        Review request for Hive Developers.

        Summary
        -------

        archive is not working when multiple partitions inside one table are archived.

        This addresses bug hive-1515.
        http://issues.apache.org/jira/browse/hive-1515

        Diffs


        trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 982490
        trunk/ql/src/test/queries/clientpositive/archive_2.q PRE-CREATION
        trunk/ql/src/test/results/clientpositive/archive_2.q.out PRE-CREATION

        Diff: http://review.cloudera.org/r/598/diff

        Testing
        -------

        Thanks,

        Yongqiang

        Show
        HBase Review Board added a comment - Message from: "Yongqiang He" <heyongqiangict@gmail.com> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/598/ ----------------------------------------------------------- Review request for Hive Developers. Summary ------- archive is not working when multiple partitions inside one table are archived. This addresses bug hive-1515. http://issues.apache.org/jira/browse/hive-1515 Diffs trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 982490 trunk/ql/src/test/queries/clientpositive/archive_2.q PRE-CREATION trunk/ql/src/test/results/clientpositive/archive_2.q.out PRE-CREATION Diff: http://review.cloudera.org/r/598/diff Testing ------- Thanks, Yongqiang
        He Yongqiang made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Affects Version/s 0.7.0 [ 12315150 ]
        He Yongqiang made changes -
        Attachment hive-1515.1.patch [ 12451450 ]
        He Yongqiang made changes -
        Field Original Value New Value
        Assignee He Yongqiang [ he yongqiang ]
        He Yongqiang created issue -

          People

          • Assignee:
            Unassigned
            Reporter:
            He Yongqiang
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:

              Development