Hive
  1. Hive
  2. HIVE-1470

percentile_approx() fails with more than 1 reducer

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.6.0
    • Fix Version/s: 0.7.0
    • Component/s: Query Processor
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The larger issue is that a UDAF that has variable return types needs two inner Evaluator classes. This patch fixes a NullPointerException bug that is only encountered when partial aggregations are invoked.

      1. HIVE-1470.2.patch
        19 kB
        Mayank Lahiri
      2. HIVE-1470.1.patch
        8 kB
        Mayank Lahiri

        Activity

        Hide
        John Sichi added a comment -

        Unit test?

        Show
        John Sichi added a comment - Unit test?
        Hide
        John Sichi added a comment -

        Oh...if it requires more than one reducer, we'll need minimr mode in order to exercise it, meaning I need to finish HIVE-117.

        Show
        John Sichi added a comment - Oh...if it requires more than one reducer, we'll need minimr mode in order to exercise it, meaning I need to finish HIVE-117 .
        Hide
        Mayank Lahiri added a comment -

        Should I create a dependency on HIVE-117? The only bit that was causing the code to crash has been removed with the split-up of the Evaluator class.

        Show
        Mayank Lahiri added a comment - Should I create a dependency on HIVE-117 ? The only bit that was causing the code to crash has been removed with the split-up of the Evaluator class.
        Hide
        John Sichi added a comment -

        How about this..post an updated patch which includes the test case, setting the number of reducers explicitly. It will be ignored for now (so the test coverage won't actually be there yet), but I'll add a note on HIVE-117 that this is a test that needs to start running in minimr mode once HIVE-117 is fixed.

        Show
        John Sichi added a comment - How about this..post an updated patch which includes the test case, setting the number of reducers explicitly. It will be ignored for now (so the test coverage won't actually be there yet), but I'll add a note on HIVE-117 that this is a test that needs to start running in minimr mode once HIVE-117 is fixed.
        Hide
        Mayank Lahiri added a comment -

        Added multiple reducers to test case, for eventual testing with minimr mode.

        Show
        Mayank Lahiri added a comment - Added multiple reducers to test case, for eventual testing with minimr mode.
        Hide
        John Sichi added a comment -

        +1. Will commit when tests pass.

        Show
        John Sichi added a comment - +1. Will commit when tests pass.
        Hide
        John Sichi added a comment -

        Committed. Thanks Mayank!

        Show
        John Sichi added a comment - Committed. Thanks Mayank!

          People

          • Assignee:
            Mayank Lahiri
            Reporter:
            Mayank Lahiri
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development