Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-1469

replace isArray() calls and remove LOG.isInfoEnabled() in Operator.forward()

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.7.0
    • Fix Version/s: 0.7.0
    • Component/s: None
    • Labels:
      None

      Description

      Small changes:
      In my profiling, isArray() is kind of expensive, we should avoid to call it.
      Also LOG.isInfoEnabled() is called in every operator's forward() method. We should only call it once.

        Activity

        Hide
        he yongqiang He Yongqiang added a comment -

        patch for review. passes all tests in my local.

        Show
        he yongqiang He Yongqiang added a comment - patch for review. passes all tests in my local.
        Hide
        nzhang Ning Zhang added a comment -

        +1.
        Will commit if tests pass.

        Show
        nzhang Ning Zhang added a comment - +1. Will commit if tests pass.
        Hide
        nzhang Ning Zhang added a comment -

        Committed. Thanks Yongqiang!

        Show
        nzhang Ning Zhang added a comment - Committed. Thanks Yongqiang!

          People

          • Assignee:
            he yongqiang He Yongqiang
            Reporter:
            he yongqiang He Yongqiang
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development