Hive
  1. Hive
  2. HIVE-1469

replace isArray() calls and remove LOG.isInfoEnabled() in Operator.forward()

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.7.0
    • Fix Version/s: 0.7.0
    • Component/s: None
    • Labels:
      None

      Description

      Small changes:
      In my profiling, isArray() is kind of expensive, we should avoid to call it.
      Also LOG.isInfoEnabled() is called in every operator's forward() method. We should only call it once.

        Activity

        He Yongqiang created issue -
        Hide
        He Yongqiang added a comment -

        patch for review. passes all tests in my local.

        Show
        He Yongqiang added a comment - patch for review. passes all tests in my local.
        He Yongqiang made changes -
        Field Original Value New Value
        Attachment hive-1469.1.patch [ 12449731 ]
        He Yongqiang made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Affects Version/s 0.7.0 [ 12315150 ]
        Hide
        Ning Zhang added a comment -

        +1.
        Will commit if tests pass.

        Show
        Ning Zhang added a comment - +1. Will commit if tests pass.
        Hide
        Ning Zhang added a comment -

        Committed. Thanks Yongqiang!

        Show
        Ning Zhang added a comment - Committed. Thanks Yongqiang!
        Ning Zhang made changes -
        Fix Version/s 0.7.0 [ 12315150 ]
        Resolution Fixed [ 1 ]
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Carl Steinbach made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            He Yongqiang
            Reporter:
            He Yongqiang
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development