[HIVE-14542] VirtualColumn::equals() should use object equality

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.14.0
• Fix Version/s: 2.3.0
• Component/s: Query Processor, Transactions
• Target Version/s: 2.2.0
• Assignee: Eugene Koifman
• Reporter: Gopal Vijayaraghavan
• Created: 16/Aug/16 05:37
• Updated: 21/Jul/17 18:12
• Resolved: 09/Sep/16 00:47

Description

The VirtualColumn() constructor is private and is only called to initialize 5 static objects.

There's no reason for VirtualColumn::equals() to do a deep type inspection for each access of a complex type like ROW__ID.

  else if(vc.equals(VirtualColumn.ROWID)) {
        if(ctx.getIoCxt().getRecordIdentifier() == null) {
          vcValues[i] = null;
        }