Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-14542

VirtualColumn::equals() should use object equality

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.14.0
    • Fix Version/s: 2.3.0
    • Labels:
      None
    • Target Version/s:

      Description

      The VirtualColumn() constructor is private and is only called to initialize 5 static objects.

      There's no reason for VirtualColumn::equals() to do a deep type inspection for each access of a complex type like ROW__ID.

        else if(vc.equals(VirtualColumn.ROWID)) {
              if(ctx.getIoCxt().getRecordIdentifier() == null) {
                vcValues[i] = null;
              }
      

        Attachments

        1. virtual-columns.png
          174 kB
          Gopal Vijayaraghavan
        2. HIVE-14542.patch
          2 kB
          Eugene Koifman
        3. HIVE-14542.3.patch
          8 kB
          Eugene Koifman
        4. HIVE-14542.4.patch
          8 kB
          Eugene Koifman
        5. HIVE-14542.5.patch
          8 kB
          Eugene Koifman
        6. HIVE-14542.6.patch
          8 kB
          Eugene Koifman

          Activity

            People

            • Assignee:
              ekoifman Eugene Koifman
              Reporter:
              gopalv Gopal Vijayaraghavan
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: