edwardcapriolo requested code review of "
HIVE-1444 [jira] "hdfs" is hardcoded in few places in the code which inhibits use of other file systems".
Allows other fs implementations then HDFS
In quite a few places "hdfs" is hardcoded, which is OK for majority of the cases, except when it is not really hdfs, but s3 or any other file system.
The place where it really breaks is:
in ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java :
method: private void applyConstraints(URI fromURI, URI toURI, Tree ast, boolean isLocal)
First few lines are check for file system:
throw new SemanticException(ErrorMsg.INVALID_PATH.getMsg(ast,
"only \"file\" or \"hdfs\" file systems accepted"));
"hdfs" is hardcoded.
I don't think you need to have this check at all as you are checking whether filesystem is local or not later on anyway and in regards to non locla file system - if one would be bad one you would get problems or have it look like local before you even come to "applyConstraints" method.
MANAGE HERALD DIFFERENTIAL RULES
WHY DID I GET THIS EMAIL?
Tip: use the X-Herald-Rules header to filter Herald messages in your client.