[HIVE-14226] Invalid check on an ASTNode#toStringTree in CalcitePlanner

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.2.0
• Assignee: Barna Zsombor Klara
• Reporter: Barna Zsombor Klara
• Created: 13/Jul/16 14:24
• Updated: 27/Feb/24 22:23
• Resolved: 16/Jul/16 19:08

Description

The patch for HIVE-12590 has modified the string tree representation of an ASTNode, so that everything except string literals are now lowercase.
However CalcitePlanner#genSelectLogicalPlan is still checking the occurrence of an uppercase TOK_FUNCTIONDI constant in the string tree.
(Line 2997 in CalcitePlanner on master)

I think this check will never evaluate to true, so we should either be using a lowercase String, or remove the check if it is unnecessary.