Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-14226

Invalid check on an ASTNode#toStringTree in CalcitePlanner

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.2.0
    • Component/s: None
    • Labels:
      None

      Description

      The patch for HIVE-12590 has modified the string tree representation of an ASTNode, so that everything except string literals are now lowercase.
      However CalcitePlanner#genSelectLogicalPlan is still checking the occurrence of an uppercase TOK_FUNCTIONDI constant in the string tree.
      (Line 2997 in CalcitePlanner on master)

      I think this check will never evaluate to true, so we should either be using a lowercase String, or remove the check if it is unnecessary.

        Attachments

        1. HIVE-14226.patch
          2 kB
          Barna Zsombor Klara

          Activity

            People

            • Assignee:
              zsombor.klara Barna Zsombor Klara
              Reporter:
              zsombor.klara Barna Zsombor Klara
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: