[HIVE-13966] DbNotificationListener: can loose DDL operation notifications

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 2.2.0
• Component/s: HCatalog
• Labels: TODOC2.2
• Assignee: Mohit Sabharwal
• Reporter: Nachiket Vaidya
• Created: 07/Jun/16 22:23
• Updated: 01/Oct/19 22:07
• Resolved: 14/Nov/16 17:17

Description

The code for each API in HiveMetaStore.java is like this:

1. openTransaction()
2. – operation--
3. commit() or rollback() based on result of the operation.
4. add entry to notification log (unconditionally)

If the operation is failed (in step 2), we still add entry to notification log. Found this issue in testing.
It is still ok as this is the case of false positive.

If the operation is successful and adding to notification log failed, the user will get an MetaException. It will not rollback the operation, as it is already committed. We need to handle this case so that we will not have false negatives.

Issue Links

• is duplicated by: HIVE-14911 Notification entry should not be written for failed events.
• is related to: HIVE-14911 Notification entry should not be written for failed events.
• is related to: HIVE-14841 Replication - Phase 2
• relates to: HIVE-2038 Metastore listener
• links to: review board