Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-13255

FloatTreeReader.nextVector is expensive

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 2.1.0
    • 2.0.1, 2.1.0
    • ORC
    • None

    Description

      Some TPCDS queries on 1TB scale shows FloatTreeReader on profile samples. It is most likely because of multiple branching and polymorphic dispatch in FloatTreeReader.nextVector() implementation. See attached image for sampling profile output.

      Attachments

        1. HIVE-13255.2.patch
          20 kB
          Prasanth Jayachandran
        2. HIVE-13255.1.patch
          19 kB
          Prasanth Jayachandran
        3. float-reader-perf.png
          144 kB
          Prasanth Jayachandran
        4. bytecode-size-before.png
          73 kB
          Prasanth Jayachandran
        5. bytecode-size-after.png
          71 kB
          Prasanth Jayachandran
        6. q1-warm-perf-map.png
          138 kB
          Prasanth Jayachandran
        7. q1-bottleneck.png
          107 kB
          Prasanth Jayachandran

        Activity

          People

            prasanth_j Prasanth Jayachandran
            prasanth_j Prasanth Jayachandran
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: