Hive
  1. Hive
  2. HIVE-1310

Partitioning columns should be of primitive types only

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.8.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      If the user specify the partitioning column as complex type (e.g., array, map) we should throw an error in semantic analyzer.

      1. hive-1310.patch
        3 kB
        Ashutosh Chauhan
      2. ASF.LICENSE.NOT.GRANTED--D225.1.patch
        3 kB
        Phabricator
      3. ASF.LICENSE.NOT.GRANTED--D225.2.patch
        2 kB
        Phabricator

        Activity

        Hide
        Ashutosh Chauhan added a comment -

        This is dangerous, since we first let user create table partitioned on complex type which we can not handle well later on. Patch which checks for this in SemanticAnalyzer

        Show
        Ashutosh Chauhan added a comment - This is dangerous, since we first let user create table partitioned on complex type which we can not handle well later on. Patch which checks for this in SemanticAnalyzer
        Hide
        Ashutosh Chauhan added a comment -

        Ready for review

        Show
        Ashutosh Chauhan added a comment - Ready for review
        Hide
        Phabricator added a comment -

        njain requested code review of "HIVE-1310 [jira] Partitioning columns should be of primitive types only".
        Reviewers: JIRA

        HIVE-1310

        If the user specify the partitioning column as complex type (e.g., array, map) we should throw an error in semantic analyzer.

        TEST PLAN
        EMPTY

        REVISION DETAIL
        https://reviews.facebook.net/D225

        AFFECTED FILES
        ql/src/test/results/clientnegative/part_col_complex_type.q.out
        ql/src/test/queries/clientnegative/part_col_complex_type.q
        ql/src/java/org/apache/hadoop/hive/ql/parse/ErrorMsg.java
        ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java

        MANAGE HERALD DIFFERENTIAL RULES
        https://reviews.facebook.net/herald/view/differential/

        WHY DID I GET THIS EMAIL?
        https://reviews.facebook.net/herald/transcript/429/

        Tip: use the X-Herald-Rules header to filter Herald messages in your client.

        Show
        Phabricator added a comment - njain requested code review of " HIVE-1310 [jira] Partitioning columns should be of primitive types only". Reviewers: JIRA HIVE-1310 If the user specify the partitioning column as complex type (e.g., array, map) we should throw an error in semantic analyzer. TEST PLAN EMPTY REVISION DETAIL https://reviews.facebook.net/D225 AFFECTED FILES ql/src/test/results/clientnegative/part_col_complex_type.q.out ql/src/test/queries/clientnegative/part_col_complex_type.q ql/src/java/org/apache/hadoop/hive/ql/parse/ErrorMsg.java ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/429/ Tip: use the X-Herald-Rules header to filter Herald messages in your client.
        Hide
        Namit Jain added a comment -

        +1

        Show
        Namit Jain added a comment - +1
        Hide
        Namit Jain added a comment -

        Committed. Thanks Ashutosh

        Show
        Namit Jain added a comment - Committed. Thanks Ashutosh
        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-h0.21 #1054 (See https://builds.apache.org/job/Hive-trunk-h0.21/1054/)
        HIVE-1310 Partitioning columns should be of primitive types only
        (Ashutosh Chauhan via namit)

        namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1196944
        Files :

        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ErrorMsg.java
        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
        • /hive/trunk/ql/src/test/queries/clientnegative/part_col_complex_type.q
        • /hive/trunk/ql/src/test/results/clientnegative/part_col_complex_type.q.out
        Show
        Hudson added a comment - Integrated in Hive-trunk-h0.21 #1054 (See https://builds.apache.org/job/Hive-trunk-h0.21/1054/ ) HIVE-1310 Partitioning columns should be of primitive types only (Ashutosh Chauhan via namit) namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1196944 Files : /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ErrorMsg.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java /hive/trunk/ql/src/test/queries/clientnegative/part_col_complex_type.q /hive/trunk/ql/src/test/results/clientnegative/part_col_complex_type.q.out
        Hide
        Phabricator added a comment -

        njain updated the revision "HIVE-1310 [jira] Partitioning columns should be of primitive types only".
        Reviewers: JIRA

        HIVE-1237 For review

        REVISION DETAIL
        https://reviews.facebook.net/D225

        AFFECTED FILES
        ql/src/test/results/clientnegative/coalesce_null.q.out
        ql/src/test/queries/clientnegative/coalesce_null.q
        ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFCoalesce.java

        Show
        Phabricator added a comment - njain updated the revision " HIVE-1310 [jira] Partitioning columns should be of primitive types only". Reviewers: JIRA HIVE-1237 For review REVISION DETAIL https://reviews.facebook.net/D225 AFFECTED FILES ql/src/test/results/clientnegative/coalesce_null.q.out ql/src/test/queries/clientnegative/coalesce_null.q ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFCoalesce.java

          People

          • Assignee:
            Ashutosh Chauhan
            Reporter:
            Ning Zhang
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development