[HIVE-13014] RetryingMetaStoreClient is retrying acid related calls too aggressievley

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 1.0.0
• Fix Version/s: 2.2.0
• Component/s: Metastore, Transactions
• Target Version/s: 2.2.0
• Assignee: Eugene Koifman
• Reporter: Eugene Koifman
• Created: 05/Feb/16 18:16
• Updated: 27/Feb/24 22:23
• Resolved: 24/Jan/17 21:01

Description

Not all metastore operations are idempotent. For example, commit_txn() consists of
1. request from client to server
2. server action
3. ack to client

If network connection is broken after (or during) 2 but before 3 happens, RetryingMetastoreClient will retry the operation thus causing an attempt to commit the same txn twice (sometimes in concurrently)

The 2nd attempt is guaranteed to fail and thus return an error to the caller (which doesn't know the operation is being retried), while the first attempt has actually succeeded. Thus the caller thinks commit failed and will likely attempt to redo the transactions - not what we want in most cases.

Issue Links

• relates to: HIVE-15715 RetryingMetaStoreClient is retrying operations too aggressievley